From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzhAx-0005yM-LK for qemu-devel@nongnu.org; Fri, 20 Nov 2015 03:36:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzhAs-0006Yp-J8 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 03:36:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzhAs-0006Yf-Ai for qemu-devel@nongnu.org; Fri, 20 Nov 2015 03:36:06 -0500 Date: Fri, 20 Nov 2015 10:36:03 +0200 From: "Michael S. Tsirkin" Message-ID: <20151120103519-mutt-send-email-mst@redhat.com> References: <1447939696-28930-1-git-send-email-mst@redhat.com> <1447939696-28930-9-git-send-email-mst@redhat.com> <20151119224209-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bandan Das Cc: Peter Maydell , Markus Armbruster , qemu-devel@nongnu.org On Thu, Nov 19, 2015 at 03:55:35PM -0500, Bandan Das wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > From: Bandan Das > >> > > >> > There's no indication of any sort that i440fx doesn't support > >> > "iommu=on" > >> > >> Oh, Markus quite didn't like this approach because this is > >> true for all other machines too. Anyway, I will keep in > >> mind to take care of this when I post a generic patch. > > > > Do you think I should revert this one then? > > Yes please, if you can. Or else, I will fix it up when I post > a generic patch later. Revert these two then? commit 8d211f622b11ac2877c344f29de284d5a842d9d7 Author: Bandan Das Date: Fri Nov 13 01:55:48 2015 -0500 i440fx: print an error message if user tries to enable iommu There's no indication of any sort that i440fx doesn't support "iommu=on" Reviewed-by: Eric Blake Signed-off-by: Bandan Das Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Eric Blake Signed-off-by: Bandan Das commit 1f8431f42d833e8914f2d16ce4a49b7b72b90db0 Author: Bandan Das Date: Fri Nov 13 01:55:47 2015 -0500 q35: Check propery to determine if iommu is set The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Signed-off-by: Bandan Das Or just one of these? > >> > Reviewed-by: Eric Blake > >> > Signed-off-by: Bandan Das > >> > Reviewed-by: Michael S. Tsirkin > >> > Signed-off-by: Michael S. Tsirkin > >> > Reviewed-by: Eric Blake > >> > Signed-off-by: Bandan Das > >> > --- > >> > hw/pci-host/piix.c | 5 +++++ > >> > 1 file changed, 5 insertions(+) > >> > > >> > diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c > >> > index 7b2fbf9..715208b 100644 > >> > --- a/hw/pci-host/piix.c > >> > +++ b/hw/pci-host/piix.c > >> > @@ -34,6 +34,7 @@ > >> > #include "sysemu/sysemu.h" > >> > #include "hw/i386/ioapic.h" > >> > #include "qapi/visitor.h" > >> > +#include "qemu/error-report.h" > >> > > >> > /* > >> > * I440FX chipset data sheet. > >> > @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) > >> > static void i440fx_realize(PCIDevice *dev, Error **errp) > >> > { > >> > dev->config[I440FX_SMRAM] = 0x02; > >> > + > >> > + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { > >> > + error_report("warning: i440fx doesn't support emulated iommu"); > >> > + } > >> > } > >> > > >> > PCIBus *i440fx_init(const char *host_type, const char *pci_type,