From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58097)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZzlFD-0003PP-19
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 07:56:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZzlF8-0000e1-UB
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 07:56:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33600)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZzlF8-0000dm-OW
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 07:56:46 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 37B68A0766
	for <qemu-devel@nongnu.org>; Fri, 20 Nov 2015 12:56:46 +0000 (UTC)
Date: Fri, 20 Nov 2015 14:56:43 +0200
From: Victor Kaplansky <victork@redhat.com>
Message-ID: <20151120145500-mutt-send-email-victork@redhat.com>
References: <1447692378-28209-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447692378-28209-1-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote:
> We are currently only sending VRING_ENABLE message for the first ring,
> that's wrong: we must start/stop them all.
> 
> Reported-by:  Victor Kaplansky <victork@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Changes from v1:
>     typo fix
> 
>  hw/virtio/vhost-user.c | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 5bc6c45..71c3e16 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -333,18 +333,23 @@ static int vhost_user_set_vring_base(struct vhost_dev *dev,
>  
>  static int vhost_user_set_vring_enable(struct vhost_dev *dev, int enable)
>  {
> -    struct vhost_vring_state state = {
> -        .index = dev->vq_index,
> -        .num   = enable,
> -    };
> +    int i;
>  
>      if (!virtio_has_feature(dev->features, VHOST_USER_F_PROTOCOL_FEATURES)) {
>          return -1;
>      }
>  
> -    return vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
> -}
> +    for (i = 0; i < dev->nvqs; ++i) {
> +        struct vhost_vring_state state = {
> +            .index = dev->vq_index + i,
> +            .num   = enable,
> +        };
> +
> +        vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);

Just noted that the patch make vhost_user_set_vring_enable() to
ignore the return value of vhost_set_vring()

> +    }
>  
> +    return 0;
> +}
>  
>  static int vhost_user_get_vring_base(struct vhost_dev *dev,
>                                       struct vhost_vring_state *ring)
> -- 
> MST