* [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings
@ 2015-11-16 16:47 Michael S. Tsirkin
2015-11-16 17:21 ` Michael S. Tsirkin
2015-11-20 12:56 ` Victor Kaplansky
0 siblings, 2 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2015-11-16 16:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Victor Kaplansky
We are currently only sending VRING_ENABLE message for the first ring,
that's wrong: we must start/stop them all.
Reported-by: Victor Kaplansky <victork@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes from v1:
typo fix
hw/virtio/vhost-user.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 5bc6c45..71c3e16 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -333,18 +333,23 @@ static int vhost_user_set_vring_base(struct vhost_dev *dev,
static int vhost_user_set_vring_enable(struct vhost_dev *dev, int enable)
{
- struct vhost_vring_state state = {
- .index = dev->vq_index,
- .num = enable,
- };
+ int i;
if (!virtio_has_feature(dev->features, VHOST_USER_F_PROTOCOL_FEATURES)) {
return -1;
}
- return vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
-}
+ for (i = 0; i < dev->nvqs; ++i) {
+ struct vhost_vring_state state = {
+ .index = dev->vq_index + i,
+ .num = enable,
+ };
+
+ vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
+ }
+ return 0;
+}
static int vhost_user_get_vring_base(struct vhost_dev *dev,
struct vhost_vring_state *ring)
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings
2015-11-16 16:47 [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings Michael S. Tsirkin
@ 2015-11-16 17:21 ` Michael S. Tsirkin
2015-11-20 12:56 ` Victor Kaplansky
1 sibling, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2015-11-16 17:21 UTC (permalink / raw)
To: qemu-devel; +Cc: Victor Kaplansky
On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote:
> We are currently only sending VRING_ENABLE message for the first ring,
> that's wrong: we must start/stop them all.
>
> Reported-by: Victor Kaplansky <victork@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Note: this is on top of my tree.
> ---
>
> Changes from v1:
> typo fix
>
> hw/virtio/vhost-user.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 5bc6c45..71c3e16 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -333,18 +333,23 @@ static int vhost_user_set_vring_base(struct vhost_dev *dev,
>
> static int vhost_user_set_vring_enable(struct vhost_dev *dev, int enable)
> {
> - struct vhost_vring_state state = {
> - .index = dev->vq_index,
> - .num = enable,
> - };
> + int i;
>
> if (!virtio_has_feature(dev->features, VHOST_USER_F_PROTOCOL_FEATURES)) {
> return -1;
> }
>
> - return vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
> -}
> + for (i = 0; i < dev->nvqs; ++i) {
> + struct vhost_vring_state state = {
> + .index = dev->vq_index + i,
> + .num = enable,
> + };
> +
> + vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
> + }
>
> + return 0;
> +}
>
> static int vhost_user_get_vring_base(struct vhost_dev *dev,
> struct vhost_vring_state *ring)
> --
> MST
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings
2015-11-16 16:47 [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings Michael S. Tsirkin
2015-11-16 17:21 ` Michael S. Tsirkin
@ 2015-11-20 12:56 ` Victor Kaplansky
2015-11-20 13:12 ` Michael S. Tsirkin
1 sibling, 1 reply; 4+ messages in thread
From: Victor Kaplansky @ 2015-11-20 12:56 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel
On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote:
> We are currently only sending VRING_ENABLE message for the first ring,
> that's wrong: we must start/stop them all.
>
> Reported-by: Victor Kaplansky <victork@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Changes from v1:
> typo fix
>
> hw/virtio/vhost-user.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 5bc6c45..71c3e16 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -333,18 +333,23 @@ static int vhost_user_set_vring_base(struct vhost_dev *dev,
>
> static int vhost_user_set_vring_enable(struct vhost_dev *dev, int enable)
> {
> - struct vhost_vring_state state = {
> - .index = dev->vq_index,
> - .num = enable,
> - };
> + int i;
>
> if (!virtio_has_feature(dev->features, VHOST_USER_F_PROTOCOL_FEATURES)) {
> return -1;
> }
>
> - return vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
> -}
> + for (i = 0; i < dev->nvqs; ++i) {
> + struct vhost_vring_state state = {
> + .index = dev->vq_index + i,
> + .num = enable,
> + };
> +
> + vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
Just noted that the patch make vhost_user_set_vring_enable() to
ignore the return value of vhost_set_vring()
> + }
>
> + return 0;
> +}
>
> static int vhost_user_get_vring_base(struct vhost_dev *dev,
> struct vhost_vring_state *ring)
> --
> MST
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings
2015-11-20 12:56 ` Victor Kaplansky
@ 2015-11-20 13:12 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2015-11-20 13:12 UTC (permalink / raw)
To: Victor Kaplansky; +Cc: qemu-devel
On Fri, Nov 20, 2015 at 02:56:43PM +0200, Victor Kaplansky wrote:
> On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote:
> > We are currently only sending VRING_ENABLE message for the first ring,
> > that's wrong: we must start/stop them all.
> >
> > Reported-by: Victor Kaplansky <victork@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Changes from v1:
> > typo fix
> >
> > hw/virtio/vhost-user.c | 17 +++++++++++------
> > 1 file changed, 11 insertions(+), 6 deletions(-)
> >
> > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> > index 5bc6c45..71c3e16 100644
> > --- a/hw/virtio/vhost-user.c
> > +++ b/hw/virtio/vhost-user.c
> > @@ -333,18 +333,23 @@ static int vhost_user_set_vring_base(struct vhost_dev *dev,
> >
> > static int vhost_user_set_vring_enable(struct vhost_dev *dev, int enable)
> > {
> > - struct vhost_vring_state state = {
> > - .index = dev->vq_index,
> > - .num = enable,
> > - };
> > + int i;
> >
> > if (!virtio_has_feature(dev->features, VHOST_USER_F_PROTOCOL_FEATURES)) {
> > return -1;
> > }
> >
> > - return vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
> > -}
> > + for (i = 0; i < dev->nvqs; ++i) {
> > + struct vhost_vring_state state = {
> > + .index = dev->vq_index + i,
> > + .num = enable,
> > + };
> > +
> > + vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state);
>
> Just noted that the patch make vhost_user_set_vring_enable() to
> ignore the return value of vhost_set_vring()
Right. But all callers ignore the return value of this function ATM
so I don't think it's a big deal.
> > + }
> >
> > + return 0;
> > +}
> >
> > static int vhost_user_get_vring_base(struct vhost_dev *dev,
> > struct vhost_vring_state *ring)
> > --
> > MST
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-20 13:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 16:47 [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings Michael S. Tsirkin
2015-11-16 17:21 ` Michael S. Tsirkin
2015-11-20 12:56 ` Victor Kaplansky
2015-11-20 13:12 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).