From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzlUL-0003wc-45 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:12:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzlUF-0005NS-GU for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:12:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzlUF-0005NM-AE for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:12:23 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1C670537B for ; Fri, 20 Nov 2015 13:12:22 +0000 (UTC) Date: Fri, 20 Nov 2015 15:12:19 +0200 From: "Michael S. Tsirkin" Message-ID: <20151120151150-mutt-send-email-mst@redhat.com> References: <1447692378-28209-1-git-send-email-mst@redhat.com> <20151120145500-mutt-send-email-victork@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151120145500-mutt-send-email-victork@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Victor Kaplansky Cc: qemu-devel@nongnu.org On Fri, Nov 20, 2015 at 02:56:43PM +0200, Victor Kaplansky wrote: > On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote: > > We are currently only sending VRING_ENABLE message for the first ring, > > that's wrong: we must start/stop them all. > > > > Reported-by: Victor Kaplansky > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Changes from v1: > > typo fix > > > > hw/virtio/vhost-user.c | 17 +++++++++++------ > > 1 file changed, 11 insertions(+), 6 deletions(-) > > > > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c > > index 5bc6c45..71c3e16 100644 > > --- a/hw/virtio/vhost-user.c > > +++ b/hw/virtio/vhost-user.c > > @@ -333,18 +333,23 @@ static int vhost_user_set_vring_base(struct vhost_dev *dev, > > > > static int vhost_user_set_vring_enable(struct vhost_dev *dev, int enable) > > { > > - struct vhost_vring_state state = { > > - .index = dev->vq_index, > > - .num = enable, > > - }; > > + int i; > > > > if (!virtio_has_feature(dev->features, VHOST_USER_F_PROTOCOL_FEATURES)) { > > return -1; > > } > > > > - return vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state); > > -} > > + for (i = 0; i < dev->nvqs; ++i) { > > + struct vhost_vring_state state = { > > + .index = dev->vq_index + i, > > + .num = enable, > > + }; > > + > > + vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state); > > Just noted that the patch make vhost_user_set_vring_enable() to > ignore the return value of vhost_set_vring() Right. But all callers ignore the return value of this function ATM so I don't think it's a big deal. > > + } > > > > + return 0; > > +} > > > > static int vhost_user_get_vring_base(struct vhost_dev *dev, > > struct vhost_vring_state *ring) > > -- > > MST