From: Borislav Petkov <bp@alien8.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Eduardo Habkost <ehabkost@redhat.com>, KVM <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default
Date: Sat, 21 Nov 2015 02:09:25 +0100 [thread overview]
Message-ID: <20151121010925.GB3994@pd.tnic> (raw)
In-Reply-To: <564FA8A7.3000500@suse.de>
On Sat, Nov 21, 2015 at 12:11:35AM +0100, Andreas Färber wrote:
> Hi,
>
> CC'ing qemu-devel.
Ah, thanks.
> Am 21.11.2015 um 00:01 schrieb Borislav Petkov:
> > From: Borislav Petkov <bp@suse.de>
> >
> > Software Error Recovery, i.e. SER, is purely an Intel feature and it
> > shouldn't be set by default. Enable it only on Intel.
>
> Is this new in 2.5? Otherwise we would probably need compatibility code
> in pc*.[ch] for incoming live migration from older versions.
It looks it is really old, AFAIK from 2010:
c0532a76b407 ("MCE: Relay UCR MCE to guest")
You'd need to be more verbose about pc*.[ch]. An example perhaps...?
> > mcg_cap &= MCE_CAP_DEF;
> > mcg_cap |= banks;
> > +
> > + if (IS_INTEL_CPU(env))
> > + mcg_cap |= MCG_SER_P;
>
> Tabs and missing braces.
Ok.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-11-21 1:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1448060471-14128-1-git-send-email-bp@alien8.de>
2015-11-20 23:11 ` [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default Andreas Färber
2015-11-21 1:09 ` Borislav Petkov [this message]
2015-11-23 13:22 ` Eduardo Habkost
2015-11-23 14:47 ` Paolo Bonzini
2015-11-23 15:03 ` Borislav Petkov
2015-11-23 15:11 ` [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default) Eduardo Habkost
2015-11-23 16:43 ` Borislav Petkov
2015-11-23 19:42 ` Eduardo Habkost
2015-11-23 20:46 ` Borislav Petkov
2015-11-24 16:36 ` Eduardo Habkost
2015-11-24 18:44 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151121010925.GB3994@pd.tnic \
--to=bp@alien8.de \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).