From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a00Hk-0004Lg-OT for qemu-devel@nongnu.org; Sat, 21 Nov 2015 00:00:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a00Hh-0001Xb-GG for qemu-devel@nongnu.org; Sat, 21 Nov 2015 00:00:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a00Hh-0001Wz-Bj for qemu-devel@nongnu.org; Sat, 21 Nov 2015 00:00:25 -0500 Date: Sat, 21 Nov 2015 10:30:18 +0530 From: Amit Shah Message-ID: <20151121050018.GA20147@grmbl.mre> References: <1447946868-11670-1-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447946868-11670-1-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: borntraeger@de.ibm.com, qemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com, quintela@redhat.com On (Thu) 19 Nov 2015 [15:27:48], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > madvise() returns EINVAL in the case of many failures, but also > returns it in cases where the host kernel doesn't have THP enabled. > Postcopy only really cares that THP is off before it detects faults, > and turns it back on afterwards; so we're going to have > to assume that if the madvise fails then the host just doesn't do > THP and we can carry on with the postcopy. > > Signed-off-by: Dr. David Alan Gilbert > Tested-by: Jason J. Herne Reviewed-by: Amit Shah Amit