From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53767)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a0qe2-0004xB-Ut
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 07:55:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a0qdz-0000Vm-Oa
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 07:54:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53081)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a0qdz-0000Va-K5
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 07:54:55 -0500
Date: Mon, 23 Nov 2015 14:54:51 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151123145414-mutt-send-email-mst@redhat.com>
References: <1447349395-26716-1-git-send-email-ehabkost@redhat.com>
	<20151123125339.GL20436@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151123125339.GL20436@thinpad.lan.raisama.net>
Subject: Re: [Qemu-devel] [PATCH 0/2] Don't require hw_version to be set on
 every machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org, Hannes Reinecke <hare@suse.de>

On Mon, Nov 23, 2015 at 10:53:39AM -0200, Eduardo Habkost wrote:
> 
> Ping? Any thoughts on this approach?
> 
> -rc2 is too late for this kind of change, maybe?
> 

I queued this up for 2.5, will merge later this week
unless anyone objects.

> On Thu, Nov 12, 2015 at 03:29:53PM -0200, Eduardo Habkost wrote:
> > This changes the qemu_hw_version() default to "2.5+" so we don't
> > make every machine class broken by default unless they set
> > hw_version.
> > 
> > For reference, these are the current users of qemu_hw_version():
> > 
> > hw/arm/nseries.c:    pstrcat((void *) w, 12, qemu_hw_version()); /* char version[12] */
> > hw/ide/core.c:        pstrcpy(s->version, sizeof(s->version), qemu_hw_version());
> > hw/scsi/megasas.c:    snprintf(info.package_version, 0x60, "%s-QEMU", qemu_hw_version());
> > hw/scsi/scsi-bus.c:        pstrcpy((char *) &r->buf[32], 4, qemu_hw_version());
> > hw/scsi/scsi-disk.c:        s->version = g_strdup(qemu_hw_version());
> > target-i386/cpu.c:                        qemu_hw_version());
> > 
> > Cc: Andrzej Zaborowski <balrogg@gmail.com>
> > Cc: John Snow <jsnow@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Hannes Reinecke <hare@suse.de>
> > Cc: Richard Henderson <rth@twiddle.net>
> > 
> > Eduardo Habkost (2):
> >   osdep: Change default value of qemu_hw_version() to "2.5+"
> >   pc: Don't set hw_version on pc-*-2.5
> > 
> >  hw/i386/pc_piix.c    | 1 -
> >  hw/i386/pc_q35.c     | 1 -
> >  include/hw/boards.h  | 5 +++++
> >  include/qemu/osdep.h | 4 ++++
> >  util/osdep.c         | 9 ++++++++-
> >  5 files changed, 17 insertions(+), 3 deletions(-)
> > 
> > -- 
> > 2.1.0
> > 
> > 
> 
> -- 
> Eduardo