From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0tTo-0008R0-6f for qemu-devel@nongnu.org; Mon, 23 Nov 2015 10:56:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0tTk-0004sr-FM for qemu-devel@nongnu.org; Mon, 23 Nov 2015 10:56:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0tTk-0004sZ-Ar for qemu-devel@nongnu.org; Mon, 23 Nov 2015 10:56:32 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C0E14C0A1467 for ; Mon, 23 Nov 2015 15:56:31 +0000 (UTC) Date: Mon, 23 Nov 2015 15:56:27 +0000 From: "Daniel P. Berrange" Message-ID: <20151123155627.GN18085@redhat.com> References: <1448273262-13845-1-git-send-email-peterx@redhat.com> <1448273262-13845-3-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1448273262-13845-3-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH REPOST 2/2] dump-guest-memory: add basic "detach" support. Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: pbonzini@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Mon, Nov 23, 2015 at 06:07:42PM +0800, Peter Xu wrote: > This will allow the user specify "-d" (just like command > "migrate") when using "dump-guest-memory" command. When > specified, one background thread is created to do the dump work. > One flag is added to show whether there is a background dump > work in progress. Your comparison to the 'migrate' command is not entirely accurate. While the 'detach' flag exist in the QMP parameters schema, it is invalid to use it - migration is always backgrounded in QMP. [quote src="qmp-commands.hx"] (3) The user Monitor's "detach" argument is invalid in QMP and should not be used [/quote] A further difference is that with migrate, you can use 'info migrate' to determine if the operation is complete. AFAIK, with this proposal there's no way to see if the dump is complete - you just have to keep runing 'cont' until it doesn't return an error. I'm curious about the intended usage of this change and whether this design satisfies the requirements it may have Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|