From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0tgf-0005nW-8V for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:09:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0tgc-0003Sy-0d for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:09:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0tgb-0003Su-Rq for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:09:49 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 66EBFA80 for ; Mon, 23 Nov 2015 16:09:49 +0000 (UTC) Date: Mon, 23 Nov 2015 17:09:47 +0100 From: Kevin Wolf Message-ID: <20151123160947.GE4742@noname.str.redhat.com> References: <1448282346-11626-1-git-send-email-kwolf@redhat.com> <1448282346-11626-2-git-send-email-kwolf@redhat.com> <565326AF.2080605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565326AF.2080605@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] tests/Makefile: Add more dependencies for test-timed-average List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 23.11.2015 um 15:46 hat Paolo Bonzini geschrieben: > On 23/11/2015 13:39, Kevin Wolf wrote: > > tests/test-timed-average$(EXESUF): tests/test-timed-average.o qemu-timer.o \ > > libqemuutil.a stubs/clock-warp.o stubs/cpu-get-icount.o \ > > - stubs/notify-event.o stubs/replay.o > > + stubs/notify-event.o stubs/replay.o stubs/mon-is-qmp.o stubs/fd-register.o \ > > + stubs/mon-printf.o > > > > Why not just add libqemustub.a? (If it works, do not even bother > reposting). Didn't remember that that's a thing and didn't check because the rule already pulled in a few stubs manually. I'll go with the version below then. (And given that you only gave an R-b, I guess I should take this through my tree?) Kevin diff --git a/tests/Makefile b/tests/Makefile index b937984..0ef00a1 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -415,8 +415,7 @@ tests/test-vmstate$(EXESUF): tests/test-vmstate.o \ migration/qemu-file-unix.o qjson.o \ $(test-qom-obj-y) tests/test-timed-average$(EXESUF): tests/test-timed-average.o qemu-timer.o \ - libqemuutil.a stubs/clock-warp.o stubs/cpu-get-icount.o \ - stubs/notify-event.o stubs/replay.o + $(test-util-obj-y) tests/test-qapi-types.c tests/test-qapi-types.h :\ $(SRC_PATH)/tests/qapi-schema/qapi-schema-test.json $(SRC_PATH)/scripts/qapi-types.py $(qapi-py)