From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0vEq-0006jS-LX for qemu-devel@nongnu.org; Mon, 23 Nov 2015 12:49:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0vEn-0001u4-Re for qemu-devel@nongnu.org; Mon, 23 Nov 2015 12:49:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0vEn-0001tm-Kn for qemu-devel@nongnu.org; Mon, 23 Nov 2015 12:49:13 -0500 Date: Mon, 23 Nov 2015 17:49:09 +0000 From: "Daniel P. Berrange" Message-ID: <20151123174909.GS18085@redhat.com> References: <1447694618-17177-3-git-send-email-marcandre.lureau@redhat.com> <1447837378-25222-1-git-send-email-marcandre.lureau@redhat.com> <20151118224821-mutt-send-email-mst@redhat.com> <56534FAA.4090101@redhat.com> <20151123174606.GR18085@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151123174606.GR18085@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Amit Shah , marcandre.lureau@redhat.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Peter Maydell On Mon, Nov 23, 2015 at 05:46:06PM +0000, Daniel P. Berrange wrote: > On Mon, Nov 23, 2015 at 06:40:58PM +0100, Paolo Bonzini wrote: > >=20 > >=20 > > On 18/11/2015 21:49, Michael S. Tsirkin wrote: > > > On Wed, Nov 18, 2015 at 10:02:58AM +0100, marcandre.lureau@redhat.c= om wrote: > > >> From: Marc-Andr=C3=A9 Lureau > > >> > > >> vhost-user-test prints a warning. A test should not need to run on > > >> hugetlbfs, let's silence the warning under qtest. The > > >> condition can't check on qtest_enabled() since vhost-user-test act= ually > > >> doesn't use qtest accel. However, qtest_driver() can be used, if > > >> qtest_init() is called early enough. For that reason, move chardev= and > > >> qtest initialization early. > > >> > > >> Signed-off-by: Marc-Andr=C3=A9 Lureau > > >=20 > > > Seems ok, and let us bring back the 2.4 test that was > > > dropped in 2.5, but I'd like an ack on this from someone else. > >=20 > > I wonder if we need the warning at all, but this patch is okay. > >=20 > > Anyhow: > >=20 > >=20 > >=20 > > - if (qemu_opts_foreach(qemu_find_opts("object"), > > - object_create, > > - object_create_initial, NULL)) { > > + if (qemu_opts_foreach(qemu_find_opts("chardev"), > > + chardev_init_func, NULL, NULL)) { > > exit(1); > > } > >=20 > > - if (qemu_opts_foreach(qemu_find_opts("chardev"), > > - chardev_init_func, NULL, NULL)) { > > + if (qtest_chrdev) { > > + Error *local_err =3D NULL; > > + qtest_init(qtest_chrdev, qtest_log, &local_err); > > + if (local_err) { > > + error_report_err(local_err); > > + exit(1); > > + } > > + } > > + > > + if (qemu_opts_foreach(qemu_find_opts("object"), > > + object_create, > > + object_create_initial, NULL)) { > > exit(1); > > } > >=20 > >=20 > > Before: object-initial, chardev, qtest, object-late (not in the patch= ) > >=20 > > After: chardev, qtest, object-initial, object-late (not in the patch) > >=20 > > Objects must be initialized before chardev (except rng-egd) since in = the > > future chardev will need to use objects, in particular secret objects= . BTW, it was TLS credentials object that prompted my initial re-ordering, but you're right that secret objects will need creation before chardevs too, since TLS credentials will need secrets. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|