From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54828)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a13X1-0000pG-JO
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 21:40:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a13Wy-00082C-Dh
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 21:40:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43246)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a13Wy-00081o-7c
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 21:40:32 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 69663388843
	for <qemu-devel@nongnu.org>; Tue, 24 Nov 2015 02:40:31 +0000 (UTC)
Date: Tue, 24 Nov 2015 10:40:27 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151124024027.GB26733@ad.usersys.redhat.com>
References: <1448273262-13845-1-git-send-email-peterx@redhat.com>
	<1448273262-13845-2-git-send-email-peterx@redhat.com>
	<56533A71.7000607@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56533A71.7000607@redhat.com>
Subject: Re: [Qemu-devel] [PATCH REPOST 1/2] dump-guest-memory: add "detach"
 flag for QMP/HMP interfaces
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: pbonzini@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>, armbru@redhat.com

On Mon, 11/23 09:10, Eric Blake wrote:
> On 11/23/2015 03:07 AM, Peter Xu wrote:
> > This patch only add the interfaces, but not implementing them.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  dump.c           | 3 ++-
> >  hmp-commands.hx  | 5 +++--
> >  hmp.c            | 3 ++-
> >  qapi-schema.json | 3 ++-
> >  qmp-commands.hx  | 4 ++--
> >  5 files changed, 11 insertions(+), 7 deletions(-)
> > 
> 
> > +++ b/qapi-schema.json
> > @@ -2132,7 +2132,8 @@
> >  ##
> >  { 'command': 'dump-guest-memory',
> >    'data': { 'paging': 'bool', 'protocol': 'str', '*begin': 'int',
> > -            '*length': 'int', '*format': 'DumpGuestMemoryFormat' } }
> > +            '*length': 'int', '*format': 'DumpGuestMemoryFormat',
> > +            'detach': 'bool'} }
> 
> Missing documentation of the new flag, of its default state, and with a
> mention that it is '(since 2.6)'.
> 

Yes, also new flags must be added as optional to keep backward-compatibility.

Fam