From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a16fF-000499-D6 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 01:01:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a16fE-0001Jr-I5 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 01:01:17 -0500 Date: Tue, 24 Nov 2015 14:34:52 +1100 From: David Gibson Message-ID: <20151124033452.GJ26118@voom.fritz.box> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-32-git-send-email-benh@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVh9lyqKgK19OcEf" Content-Disposition: inline In-Reply-To: <1447201710-10229-32-git-send-email-benh@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 31/77] ppc/xics: Remove unused xics_set_irq_type() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --EVh9lyqKgK19OcEf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 11, 2015 at 11:27:44AM +1100, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson In fact, this is a sufficiently good clean up that I think I'll merge it shortly, regardless of what happens with the rest of the pnv series. > --- > hw/intc/xics.c | 11 ----------- > include/hw/ppc/xics.h | 1 - > 2 files changed, 12 deletions(-) >=20 > diff --git a/hw/intc/xics.c b/hw/intc/xics.c > index 165ff0b..197df33 100644 > --- a/hw/intc/xics.c > +++ b/hw/intc/xics.c > @@ -678,17 +678,6 @@ void ics_set_irq_type(ICSState *ics, int srcno, bool= lsi) > lsi ? XICS_FLAGS_IRQ_LSI : XICS_FLAGS_IRQ_MSI; > } > =20 > -void xics_set_irq_type(XICSState *icp, int irq, bool lsi) > -{ > - int src =3D xics_find_source(icp, irq); > - ICSState *ics; > - > - assert(src >=3D 0); > - > - ics =3D &icp->ics[src]; > - ics_set_irq_type(ics, irq - ics->offset, lsi); > -} > - > /* > * XICS > */ > diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h > index ad39c8c..8e7998f 100644 > --- a/include/hw/ppc/xics.h > +++ b/include/hw/ppc/xics.h > @@ -166,7 +166,6 @@ struct ICSIRQState { > #define XICS_IRQS_SPAPR 1024 > =20 > qemu_irq xics_get_qirq(XICSState *icp, int irq); > -void xics_set_irq_type(XICSState *icp, int irq, bool lsi); > =20 > int xics_spapr_alloc(XICSState *icp, int src, int irq_hint, bool lsi); > int xics_spapr_alloc_block(XICSState *icp, int src, int num, bool lsi, b= ool align); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --EVh9lyqKgK19OcEf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWU9rcAAoJEGw4ysog2bOShW4QAJiX+xjFBspF6sP1PVzI/rGK lA3R9pyv5NpuNWSz7WjDviz9huq6ibm66hjXYrEfsCvIx5FKkhhjv6Y2eaLCtMEC B1Lp7QarHWirsdRVuTuxyg1SR3PVpvgVgUTV1cfPd8D7Zpuv/PRr4FaBlvC5rAoH CtdPNa72ZxEPch8nH+OP/qpLp7rbCPWreciXhIhnWmkv8cpuAXM/tMZWr/fB55/Z CKQlPnPj42WYt/XZt5X8oiRIP3A0wP+Iup8vTOIFn9WLt9Nkr+kWSXVt1vu6fWFG 5kZ2B/RRi2/5OohqMylXpXAhNUDJbyWKGI1zpsp4NBoNf9+oShFMPfhaYEaWZfUa fJtK56VtlHRqDnrkHzOEmWXtWn5dujkJ1DjrFxgRpmSxHsTwMpXbu5XawxUIafw5 T+blwbetD6STHfM0ITtdxJ+6Ff4tpOffGDWQfPAQv+cgsDF0lk/JvmTS07eQRpZZ 2PRiPEAkq71nWcXztCNUV7qt2EUroHhBLMRyjNG5x77zoAE+bCTdXE/K1V3mH5jP Qcr3hSLjAPBmctz+dkCnjC8BuzM1BnQ5NLeCzMTDiyRVQsFxHk0cGbPRl7IjumGk nXrEPWMsiS6kTOrfX9qMu+Q6PYBV+p+PgfaEg+CLYgdqKRCE7QN9UE02/QZyMon/ UukGDwsDVqDM7PXxqstQ =EHHD -----END PGP SIGNATURE----- --EVh9lyqKgK19OcEf--