From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a16fG-0004Aq-PU for qemu-devel@nongnu.org; Tue, 24 Nov 2015 01:01:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a16fF-0001KU-RR for qemu-devel@nongnu.org; Tue, 24 Nov 2015 01:01:18 -0500 Date: Tue, 24 Nov 2015 14:36:31 +1100 From: David Gibson Message-ID: <20151124033630.GK26118@voom.fritz.box> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-33-git-send-email-benh@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Tv3+oRj6D9L8lW+H" Content-Disposition: inline In-Reply-To: <1447201710-10229-33-git-send-email-benh@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 32/77] ppc/xics: Replace "icp" with "xics" in most places List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --Tv3+oRj6D9L8lW+H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 11, 2015 at 11:27:45AM +1100, Benjamin Herrenschmidt wrote: > The "ICP" is a different object than the "XICS". For historical reasons, > we have a number of places where we name a variable "icp" while it contai= ns > a XICSState pointer. There *is* an ICPState structure too so this makes > the code really confusing. >=20 > This is a mechanical replacement of all those instances to use the name > "xics" instead. There should be no functional change. >=20 > Signed-off-by: Benjamin Herrenschmidt Ah, good idea. I think I'll take this one independently as well. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Tv3+oRj6D9L8lW+H Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWU9s+AAoJEGw4ysog2bOSHhoP/RUh3aMwDCu7ZvMulyYm8jiG a8Yz4+Ckv1f7WcYjbJFsGag2e7Q6S5+9FnxF5gmyPc6sd2NNArInKw+Hui59MkMU LkQ4kW8heDJT78QJgPXFShPCZs3F8mFK83fY//awFeFiuy/DrUz3GvSYMJp2Aa5f EQQtlYQ0OqOEjMS/loN0by6O6T5CDBDTZ6qV8H3uSp8HyTfGMCtVV2WvBQMDvrH/ aQQ+/g+jdMY5rH3cUH6yGtcSbd3BFET2J8nk5HEEl0EuwzVSr8cA3HiX/82e2GYW 71V0/ks7tkCXVXR4sp5N0zs39ToH+vkD5wPqvDYw4qMY1eqtMkkO5veDpAvsSxcT LcfvetWNaBTmJcEfMff+aj5EuKL1+VVQ22DhGPXtwU9A7yUiAKJnyXkFDtqgm43P 2jhvylv9qHd5oaBoBLOOvNU4J+84Tamsh+OPcdu+M/l7WwIIKp69hjvDEyy3BuxY KXNFuzoH5IMBpwR4lKrNmIaoLrAt7bFAFfQW37K4eJklulCV7k0v8+8ZujDoGZpD crc6rYVImUh4orVU12erWYCADYy0tO2SULx+kxwOUwjtk1/z9C2BrSCVdNglHC9z XaKdazGgzyX+sAWv+0PyLhejoozxv8hnOB/BatrFETdwaLnlJSgDDVnYmGJVerJT kIqxUH2/b8SR/+Gs4L+K =KX6f -----END PGP SIGNATURE----- --Tv3+oRj6D9L8lW+H--