From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Fcx-0006dz-UL for qemu-devel@nongnu.org; Tue, 24 Nov 2015 10:35:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1Fcu-0004LP-PS for qemu-devel@nongnu.org; Tue, 24 Nov 2015 10:35:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Fcu-0004LD-Ke for qemu-devel@nongnu.org; Tue, 24 Nov 2015 10:35:28 -0500 Date: Tue, 24 Nov 2015 16:35:26 +0100 From: Kevin Wolf Message-ID: <20151124153526.GG4296@noname.str.redhat.com> References: <1448060035-31973-1-git-send-email-jsnow@redhat.com> <1448060035-31973-3-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448060035-31973-3-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] ide-test: cdrom_pio_impl fixup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: pl@kamp.de, qemu-devel@nongnu.org Am 20.11.2015 um 23:53 hat John Snow geschrieben: > Final tidying: move the interrupt wait into the loop, > document that the status read clears the IRQ, and move > the final interrupt check outside of the loop. > > This should be functionally equivalent to how it works > currently, but a little less ambiguous and slightly more > explicit about the state transitions. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf