From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1EJC-0006gb-Cr for qemu-devel@nongnu.org; Tue, 24 Nov 2015 09:11:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1EJ8-000807-MY for qemu-devel@nongnu.org; Tue, 24 Nov 2015 09:11:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1EJ8-0007zw-Gp for qemu-devel@nongnu.org; Tue, 24 Nov 2015 09:10:58 -0500 Date: Tue, 24 Nov 2015 16:10:54 +0200 From: "Michael S. Tsirkin" Message-ID: <20151124160921-mutt-send-email-mst@redhat.com> References: <1447694618-17177-3-git-send-email-marcandre.lureau@redhat.com> <1447837378-25222-1-git-send-email-marcandre.lureau@redhat.com> <20151118224821-mutt-send-email-mst@redhat.com> <56534FAA.4090101@redhat.com> <20151123181008.GU18085@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20151123181008.GU18085@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Amit Shah , Paolo Bonzini , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , QEMU , Peter Maydell On Mon, Nov 23, 2015 at 06:10:08PM +0000, Daniel P. Berrange wrote: > On Mon, Nov 23, 2015 at 07:01:33PM +0100, Marc-Andr=E9 Lureau wrote: > > On Mon, Nov 23, 2015 at 6:40 PM, Paolo Bonzini = wrote: > > > Before: object-initial, chardev, qtest, object-late (not in the pat= ch) > > > > > > After: chardev, qtest, object-initial, object-late (not in the patc= h) > > > > > > Objects must be initialized before chardev (except rng-egd) since i= n the > > > future chardev will need to use objects, in particular secret objec= ts. > > > Was the swap intentional? > >=20 > > Yes, without the swap, qtest was not initialized before memory is all= ocated. > >=20 > > The alternative I could think of is to check the QTEST_QEMU_BINARY > > variable: http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg= 01527.html >=20 > Why do we not simply delete the warning message about the path not > being on hugetlbfs ? ie, why does QEMU try to force a policy that > a memory-file backend has to be on hugetlbfs, as opposed to on > a plain tmpfs ? I've previously had user request that we allow > use of plain tmpfs, because they want to use vhost-user without > also using hugepages, and that could be done with plain tmpfs. >=20 > Regards, > Daniel Because THP does not work on any other filesystem, so many workloads are much slower. That's why it's a warning, not an error. > --=20 > |: http://berrange.com -o- http://www.flickr.com/photos/dberran= ge/ :| > |: http://libvirt.org -o- http://virt-manager.= org :| > |: http://autobuild.org -o- http://search.cpan.org/~danbe= rr/ :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-= vnc :|