From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1KZt-0007Nm-JK for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:52:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1KZq-0001FV-AV for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:52:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1KZq-0001FQ-5m for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:52:38 -0500 Date: Tue, 24 Nov 2015 22:52:32 +0200 From: "Michael S. Tsirkin" Message-ID: <20151124224712-mutt-send-email-mst@redhat.com> References: <1448381436-32106-1-git-send-email-thibaut.collet@6wind.com> <1448381436-32106-2-git-send-email-thibaut.collet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448381436-32106-2-git-send-email-thibaut.collet@6wind.com> Subject: Re: [Qemu-devel] [PATCH for-2.5 1/1] vhost-user: do not send SET_VRING_ENABLE at start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thibaut Collet Cc: yuanhan.liu@linux.intel.com, jasowang@redhat.com, Victor Kaplansky , marcandre.lureau@gmail.com, qemu-devel@nongnu.org On Tue, Nov 24, 2015 at 05:10:36PM +0100, Thibaut Collet wrote: > This patch reverts partially commit 3a12f32229a. > > In case of live migration several queues can be enabled and not only the first > one. So inform backend that only the first queue is enabled is wrong. > > Since commit 7263a0ad7899 backend is already notified of the state of the vring > through the vring attach operation. This function, called during the startup > sequence, provides the correct state of the vring, even in case of live > migration. > > So nothing has to be added to give the vring state to the backend at the startup. > > Signed-off-by: Thibaut Collet > --- > hw/virtio/vhost.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index 1794f0d..870cd12 100644 > --- a/hw/virtio/vhost.c > +++ b/hw/virtio/vhost.c > @@ -1226,11 +1226,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev) > } > } > > - if (hdev->vhost_ops->vhost_set_vring_enable) { > - /* only enable first vq pair by default */ > - hdev->vhost_ops->vhost_set_vring_enable(hdev, hdev->vq_index == 0); > - } > - > return 0; > fail_log: > vhost_log_put(hdev, false); > -- > 2.1.4 Yes - and I'm beginning to think that maybe we should revert all of 3a12f32229a then, for symmetry. Yunnan, Victor - what do you think? -- MST