From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43260)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a1TPR-0004QA-2h
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 01:18:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a1TPM-00012B-3p
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 01:18:29 -0500
Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:36797)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a1TPL-00011t-Qz
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 01:18:24 -0500
Received: by wmww144 with SMTP id w144so166261149wmw.1
	for <qemu-devel@nongnu.org>; Tue, 24 Nov 2015 22:18:23 -0800 (PST)
Date: Wed, 25 Nov 2015 08:18:20 +0200
From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Message-ID: <20151125081820.0c147ea8@pixies>
In-Reply-To: <56551F3B.9020106@redhat.com>
References: <1447930344-17625-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<1447930344-17625-2-git-send-email-shmulik.ladkani@ravellosystems.com>
	<56551F3B.9020106@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE
 endpoint
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>, idan.brown@ravellosystems.com, qemu-devel@nongnu.org

Thanks Jason,

On Wed, 25 Nov 2015 10:38:51 +0800, jasowang@redhat.com wrote:
> > @@ -2568,6 +2572,7 @@ static void vmxnet3_class_init(ObjectClass *class, void *data)
> >      c->class_id = PCI_CLASS_NETWORK_ETHERNET;
> >      c->subsystem_vendor_id = PCI_VENDOR_ID_VMWARE;
> >      c->subsystem_id = PCI_DEVICE_ID_VMWARE_VMXNET3;
> > +    c->is_express = 1;
> 
> Should we do this conditionally? And how about the migration
> compatibility? Looks like pcie device is using vmstate_pcie_device
> instead of vmstate_pci_device, maybe need a new property bit for this.

(Responding for the entire series)

Agreed. Will limit these changes for new versions.

What's your suggested plan?
Does it make sense to have a property for each change (as they are not
necessarily related), or is it too tedious and one property will suffice?

Regards,
Shmulik