From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54549)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1cop-0001Fn-4F
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:21:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1cok-00079h-4Q
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:21:19 -0500
Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:36859)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1cok-000797-0D
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:21:14 -0500
Received: by oiww189 with SMTP id w189so31799788oiw.3
	for <qemu-devel@nongnu.org>; Wed, 25 Nov 2015 08:21:13 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
References: <1448456352-14143-1-git-send-email-marcandre.lureau@redhat.com>
	<1448456352-14143-3-git-send-email-marcandre.lureau@redhat.com>
	<5655DBAF.3040506@redhat.com>
In-Reply-To: <5655DBAF.3040506@redhat.com>
Message-ID: <20151125162102.6284.38229@loki>
Date: Wed, 25 Nov 2015 10:21:02 -0600
Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, marcandre.lureau@redhat.com, qemu-devel@nongnu.org

Quoting Eric Blake (2015-11-25 10:02:55)
> On 11/25/2015 05:59 AM, marcandre.lureau@redhat.com wrote:
> > From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> > =

> > This test exhibits a POSIX behaviour regarding switching between write
> > and read. It's undefined result if the application doesn't ensure a
> > flush between the two operations (with glibc, the flush can be implicit
> > when the buffer size is relatively small). The previous commit fixes
> > this test.
> > =

> > Related to:
> > https://bugzilla.redhat.com/show_bug.cgi?id=3D1210246
> > =

> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> > ---
> >  tests/test-qga.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++++=
++++++--
> >  1 file changed, 93 insertions(+), 2 deletions(-)
> =

> Reviewed-by: Eric Blake <eblake@redhat.com>
> =

> > +    /* seek to 0 */
> > +    cmd =3D g_strdup_printf("{'execute': 'guest-file-seek',"
> > +                          " 'arguments': { 'handle': %" PRId64 ", "
> > +                          " 'offset': %d, 'whence': %d } }",
> > +                          id, 0, SEEK_SET);
> =

> We still have a conflict between this series and my proposal to codify 0
> rather than relying on platform-specific SEEK_SET; Markus had the
> suggestion of using QGA_SET (or QGA_SEEK_SET).  Are we trying to get
> both your series and my v2 patch into 2.5?  Knowing that will help me
> decide whether my v2 should be rebased on top of your patches.

I was planning on pulling in your patch on top of this for the next
2.5 pull, so rebasing on top of this series is probably best.

> =

> -- =

> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20