qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/2] qga: flush explicitly when needed
Date: Wed, 25 Nov 2015 10:46:39 -0600	[thread overview]
Message-ID: <20151125164639.6284.19161@loki> (raw)
In-Reply-To: <1448456352-14143-1-git-send-email-marcandre.lureau@redhat.com>

Quoting marcandre.lureau@redhat.com (2015-11-25 06:59:10)
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Without this change, a write() followed by a read() may lose the
> previously written content, as shown in the following test.
> 
> v2->v3:
> - use a RwState tristate enum
> - reset the state on flush & seek
> 
> v1->v2:
> - replace guchar with unsigned char
> - fix implicitly/explictly
> - comment space fix
> 
> Marc-André Lureau (2):
>   qga: flush explicitly when needed
>   tests: add file-write-read test

Thanks, applied with fix-ups suggested by Lazlo:

  https://github.com/mdroth/qemu/commits/qga

> 
>  qga/commands-posix.c | 37 ++++++++++++++++++++
>  tests/test-qga.c     | 95 ++++++++++++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 130 insertions(+), 2 deletions(-)
> 
> -- 
> 2.5.0
> 

  parent reply	other threads:[~2015-11-25 16:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 12:59 [Qemu-devel] [PATCH v3 0/2] qga: flush explicitly when needed marcandre.lureau
2015-11-25 12:59 ` [Qemu-devel] [PATCH v3 1/2] " marcandre.lureau
2015-11-25 15:10   ` Laszlo Ersek
2015-11-25 15:58   ` Eric Blake
2015-11-25 12:59 ` [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test marcandre.lureau
2015-11-25 16:02   ` Eric Blake
2015-11-25 16:21     ` Michael Roth
2015-11-25 16:41       ` Eric Blake
2015-11-25 16:46         ` Michael Roth
2015-11-25 17:10           ` Eric Blake
2015-11-25 17:14             ` Michael Roth
2015-11-25 17:18               ` Eric Blake
2015-11-25 17:22                 ` Michael Roth
2015-11-25 16:46 ` Michael Roth [this message]
2015-11-25 16:52   ` [Qemu-devel] [PATCH v3 0/2] qga: flush explicitly when needed Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125164639.6284.19161@loki \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).