From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dDZ-0007It-Uh for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:46:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1dDV-000690-RO for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:46:53 -0500 Received: from mail-ob0-x230.google.com ([2607:f8b0:4003:c01::230]:34944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dDV-00068t-Nl for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:46:49 -0500 Received: by obbnk6 with SMTP id nk6so42973706obb.2 for ; Wed, 25 Nov 2015 08:46:49 -0800 (PST) Sender: fluxion Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1448456352-14143-1-git-send-email-marcandre.lureau@redhat.com> References: <1448456352-14143-1-git-send-email-marcandre.lureau@redhat.com> Message-ID: <20151125164639.6284.19161@loki> Date: Wed, 25 Nov 2015 10:46:39 -0600 Subject: Re: [Qemu-devel] [PATCH v3 0/2] qga: flush explicitly when needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Quoting marcandre.lureau@redhat.com (2015-11-25 06:59:10) > From: Marc-Andr=C3=A9 Lureau > = > Without this change, a write() followed by a read() may lose the > previously written content, as shown in the following test. > = > v2->v3: > - use a RwState tristate enum > - reset the state on flush & seek > = > v1->v2: > - replace guchar with unsigned char > - fix implicitly/explictly > - comment space fix > = > Marc-Andr=C3=A9 Lureau (2): > qga: flush explicitly when needed > tests: add file-write-read test Thanks, applied with fix-ups suggested by Lazlo: https://github.com/mdroth/qemu/commits/qga > = > qga/commands-posix.c | 37 ++++++++++++++++++++ > tests/test-qga.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++= ++++-- > 2 files changed, 130 insertions(+), 2 deletions(-) > = > -- = > 2.5.0 >=20