From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1dEP-0008Ra-OG
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:47:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1dEM-0006Kj-Hu
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:47:45 -0500
Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:34329)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1dEM-0006Kf-5Z
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:47:42 -0500
Received: by oies6 with SMTP id s6so32654162oie.1
	for <qemu-devel@nongnu.org>; Wed, 25 Nov 2015 08:47:41 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <1447935637-19262-1-git-send-email-den@openvz.org>
References: <1447935637-19262-1-git-send-email-den@openvz.org>
Message-ID: <20151125164732.6284.31571@loki>
Date: Wed, 25 Nov 2015 10:47:32 -0600
Subject: Re: [Qemu-devel] [PATCH for 2.5 1/1] qga: gspawn() console helper
 to Windows guest agent msi build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Yuri Pudgorodskiy <yur@virtuozzo.com>, qemu-devel@nongnu.org

Quoting Denis V. Lunev (2015-11-19 06:20:37)
> From: Yuri Pudgorodskiy <yur@virtuozzo.com>
> =

> This helper, gspawn-win64-helper-console.exe for 64-bit and
> gspawn-win32-helper-console.exe for 32-bit environment,
> is needed for gspawn() mingw implementation, used by guest-exec command.
> =

> Without these files guest-exec command on Windows will not
> work with "file not found" diagnostic message.
> =

> Signed-off-by: Yuri Pudgorodskiy <yur@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Michael Roth <mdroth@linux.vnet.ibm.com>

Thanks, applied to qga tree:

  https://github.com/mdroth/qemu/commits/qga

> ---
>  qga/installer/qemu-ga.wxs | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> =

> diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
> index 6804f02..f25afdd 100644
> --- a/qga/installer/qemu-ga.wxs
> +++ b/qga/installer/qemu-ga.wxs
> @@ -91,6 +91,16 @@
>              <File Id=3D"qga_vss.tlb" Name=3D"qga-vss.tlb" Source=3D"$(en=
v.BUILD_DIR)/qga/vss-win32/qga-vss.tlb" KeyPath=3D"yes" DiskId=3D"1"/>
>            </Component>
>            <?endif?>
> +          <?if $(var.Arch) =3D "32"?>
> +          <Component Id=3D"gspawn-helper-console" Guid=3D"{446185B3-87BE=
-43D2-96B8-0FEFD9E8696D}">
> +            <File Id=3D"gspawn-win32-helper-console.exe" Name=3D"gspawn-=
win32-helper-console.exe" Source=3D"$(var.Mingw_bin)/gspawn-win32-helper-co=
nsole.exe" KeyPath=3D"yes" DiskId=3D"1"/>
> +          </Component>
> +          <?endif?>
> +          <?if $(var.Arch) =3D "64"?>
> +          <Component Id=3D"gspawn-helper-console" Guid=3D"{9E615A9F-349A=
-4992-A5C2-C10BAD173660}">
> +            <File Id=3D"gspawn-win64-helper-console.exe" Name=3D"gspawn-=
win64-helper-console.exe" Source=3D"$(var.Mingw_bin)/gspawn-win64-helper-co=
nsole.exe" KeyPath=3D"yes" DiskId=3D"1"/>
> +          </Component>
> +          <?endif?>
>            <Component Id=3D"iconv" Guid=3D"{35EE3558-D34B-4F0A-B8BD-430FF=
0775246}">
>              <File Id=3D"iconv.dll" Name=3D"iconv.dll" Source=3D"$(var.Mi=
ngw_bin)/iconv.dll" KeyPath=3D"yes" DiskId=3D"1"/>
>            </Component>
> @@ -148,6 +158,7 @@
>        <ComponentRef Id=3D"qga_vss_dll" />
>        <ComponentRef Id=3D"qga_vss_tlb" />
>        <?endif?>
> +      <ComponentRef Id=3D"gspawn-helper-console" />
>        <ComponentRef Id=3D"iconv" />
>        <ComponentRef Id=3D"libgcc_arch_lib" />
>        <ComponentRef Id=3D"libglib" />
> -- =

> 2.1.4
>=20