From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45231)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1deX-0000WV-9i
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:14:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1deU-0006Js-4D
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:14:45 -0500
Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:33969)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1a1deT-0006Jm-Vt
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:14:42 -0500
Received: by oies6 with SMTP id s6so33154440oie.1
	for <qemu-devel@nongnu.org>; Wed, 25 Nov 2015 09:14:41 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
References: <1448456352-14143-1-git-send-email-marcandre.lureau@redhat.com>
	<1448456352-14143-3-git-send-email-marcandre.lureau@redhat.com>
	<5655DBAF.3040506@redhat.com> <20151125162102.6284.38229@loki>
	<5655E4BF.3010604@redhat.com> <20151125164608.6284.38856@loki>
	<5655EB96.2090200@redhat.com>
In-Reply-To: <5655EB96.2090200@redhat.com>
Message-ID: <20151125171431.6284.10858@loki>
Date: Wed, 25 Nov 2015 11:14:31 -0600
Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, marcandre.lureau@redhat.com, qemu-devel@nongnu.org

Quoting Eric Blake (2015-11-25 11:10:46)
> On 11/25/2015 09:46 AM, Michael Roth wrote:
> > Quoting Eric Blake (2015-11-25 10:41:35)
> >> On 11/25/2015 09:21 AM, Michael Roth wrote:
> >>
> >>>>> +    /* seek to 0 */
> >>>>> +    cmd =3D g_strdup_printf("{'execute': 'guest-file-seek',"
> >>>>> +                          " 'arguments': { 'handle': %" PRId64 ", "
> >>>>> +                          " 'offset': %d, 'whence': %d } }",
> >>>>> +                          id, 0, SEEK_SET);
> >>>>
> >>>> We still have a conflict between this series and my proposal to codi=
fy 0
> >>>> rather than relying on platform-specific SEEK_SET; Markus had the
> >>>> suggestion of using QGA_SET (or QGA_SEEK_SET).  Are we trying to get
> >>>> both your series and my v2 patch into 2.5?  Knowing that will help me
> >>>> decide whether my v2 should be rebased on top of your patches.
> >>>
> >>> I was planning on pulling in your patch on top of this for the next
> >>> 2.5 pull, so rebasing on top of this series is probably best.
> >>
> >> Okay, will do, and will do quickly so I'm not holding up your pull req=
uest.
> > =

> > Thanks! FYI I now have this series applied here if you'd like to base
> > on that:
> > =

> >   https://github.com/mdroth/qemu/commits/qga
> =

> On that branch, commit 7a38932 has two typos:
> s/is commit msg (Lazlo)/in commit msg (Laszlo)/

Thanks, fixed now.

> =

> -- =

> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20