qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	kvm@vger.kernel.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, ying.huang@intel.com,
	"Andreas Färber" <afaerber@suse.de>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap bits
Date: Wed, 25 Nov 2015 18:35:21 +0100	[thread overview]
Message-ID: <20151125173521.GC4227@pd.tnic> (raw)
In-Reply-To: <5655EFF5.6030000@redhat.com>

On Wed, Nov 25, 2015 at 06:29:25PM +0100, Paolo Bonzini wrote:
> On 25/11/2015 18:21, Borislav Petkov wrote:
> >> Instead of silently clearing mcg_cap bits when the host doesn't
> >> > support them, print a warning when doing that.
> > Why the host? Why would we want there to be any relation between the MCA
> > capabilities of the host and what qemu is emulating?
> 
> He means the hypervisor. :)

Ah, ok. :)

Then they look good to me, a step in the right direction.

Acked-by: Borislav Petkov <bp@suse.de>

Thanks!

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

      reply	other threads:[~2015-11-25 17:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 15:49 [Qemu-devel] [PATCH 0/3] target-i386: kvm: Use env->mcg_cap when setting up MCE Eduardo Habkost
2015-11-25 15:49 ` [Qemu-devel] [PATCH 1/3] target-i386: kvm: Abort if MCE bank count is not supported by host Eduardo Habkost
2015-11-25 16:46   ` Paolo Bonzini
2015-11-25 17:26     ` Eduardo Habkost
2015-11-25 17:30       ` Paolo Bonzini
2015-11-25 15:49 ` [Qemu-devel] [PATCH 2/3] target-i386: kvm: Use env->mcg_cap when setting up MCE Eduardo Habkost
2015-11-25 15:49 ` [Qemu-devel] [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap bits Eduardo Habkost
2015-11-25 16:45   ` Paolo Bonzini
2015-11-25 17:29     ` Eduardo Habkost
2015-11-25 17:30       ` Paolo Bonzini
2015-11-25 17:21   ` Borislav Petkov
2015-11-25 17:29     ` Paolo Bonzini
2015-11-25 17:35       ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125173521.GC4227@pd.tnic \
    --to=bp@alien8.de \
    --cc=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).