Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Add /system-id

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

On Wed, Nov 25, 2015 at 04:15:01PM +0100, Alexander Graf wrote:
> 
> 
> On 18.11.15 11:49, David Gibson wrote:
> > On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey Kardashevskiy wrote:
> >> On 11/09/2015 07:47 PM, David Gibson wrote:
> >>> On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote:
> >>>> Section B.6.2.1 Root Node Properties of PAPR specification defines
> >>>> a set of properties which shall be present in the device tree root,
> >>>> one of these properties is "system-id" which "should be unique across
> >>>> all systems and all manufacturers". Since UUID is meant to be unique,
> >>>> it makes sense to use it as "system-id".
> >>>>
> >>>> This adds "system-id" property to the device tree root when not empty.
> >>>>
> >>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> >>>> ---
> >>>>
> >>>> This might be expected by AIX so here is the patch.
> >>>> I am really not sure if it makes sense to initialize property when
> >>>> UUID is all zeroes as the requirement is "unique" and zero-uuid is
> >>>> not.
> >>>
> >>> Yeah, I think it would be better to omit system-id entirely when a
> >>> UUID hasn't been supplied.
> >>
> >>
> >> so this did not go anywhere yet, did it?
> > 
> > No.
> 
> So where is it stuck?

I was waiting for a respin which didn't set the property when a UUID
hadn't been given.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]