From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1nB0-0000Pa-VU for qemu-devel@nongnu.org; Wed, 25 Nov 2015 22:24:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1nAz-0005nm-MI for qemu-devel@nongnu.org; Wed, 25 Nov 2015 22:24:54 -0500 Date: Thu, 26 Nov 2015 11:49:11 +1100 From: David Gibson Message-ID: <20151126004911.GA25500@voom.redhat.com> References: <1447051637-45246-1-git-send-email-aik@ozlabs.ru> <20151109084731.GH18558@voom.redhat.com> <564C2CA3.8000307@ozlabs.ru> <20151118104927.GA3298@voom.fritz.box> <5655D075.9020609@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n8g4imXOkfNTN/H1" Content-Disposition: inline In-Reply-To: <5655D075.9020609@suse.de> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Add /system-id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --n8g4imXOkfNTN/H1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 25, 2015 at 04:15:01PM +0100, Alexander Graf wrote: >=20 >=20 > On 18.11.15 11:49, David Gibson wrote: > > On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey Kardashevskiy wrote: > >> On 11/09/2015 07:47 PM, David Gibson wrote: > >>> On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote: > >>>> Section B.6.2.1 Root Node Properties of PAPR specification defines > >>>> a set of properties which shall be present in the device tree root, > >>>> one of these properties is "system-id" which "should be unique across > >>>> all systems and all manufacturers". Since UUID is meant to be unique, > >>>> it makes sense to use it as "system-id". > >>>> > >>>> This adds "system-id" property to the device tree root when not empt= y. > >>>> > >>>> Signed-off-by: Alexey Kardashevskiy > >>>> --- > >>>> > >>>> This might be expected by AIX so here is the patch. > >>>> I am really not sure if it makes sense to initialize property when > >>>> UUID is all zeroes as the requirement is "unique" and zero-uuid is > >>>> not. > >>> > >>> Yeah, I think it would be better to omit system-id entirely when a > >>> UUID hasn't been supplied. > >> > >> > >> so this did not go anywhere yet, did it? > >=20 > > No. >=20 > So where is it stuck? I was waiting for a respin which didn't set the property when a UUID hadn't been given. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --n8g4imXOkfNTN/H1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWVlcHAAoJEGw4ysog2bOSpnoP/122zADZtgnceqNHkxviK9jX B5fvxxLljc3tslSyB/Nrmfco3lx7myGPODVjvInTgNE38y+oN5LbpyILoXLP3FVP 8l5fU+Ua8o+9cAmA3ddQ8YIdgzipKOHaX0xs200wtQ+FbdnZIM0W8dO93dVtKawp x1fIgTLd/Kowlwy8Ci3xV5FqrpV04LzGxwh6QpdozMaj2fOX89T+phLeAj0AM2lc ZQ2SdoZxST9lN7P70yn2OiCi++OEaxQ3djAsXw06z7Bga/s6eEtZgg5DapuRNKK3 SvZFOjdEf0Y9JWJjhlGGxxXuuEqOfcfI6BAvpNUcFyoUX94w2AoLvoqaVZ/kKJLB ES1eOP+psdpxyxuvypVureXh0fRHFl7973o2fMBmAN0igP6reI/PlFlJDmRnoLpC kk7UEUFwttaEs5G++U5QQeHSPLr6veUTcN2pz//EfMLymh5OHzlvWQXbp9yGfunH WYZWorgMTRaZbUkSvewQyctY0Dg3gZoRtsS7reTwTFDE67gjl4Wd+VfYslIt2CbX wSbOo1hsQRJmYP1JvYq8yGyp8Sh9RO8kr/7T400fcl6SymSp4FhUMSI1WhtloYQA Ze48ZVaFL0CVEOeX7Sxp0fqtwpNI/diW8j4fAubGLBc2O6qn4m8b1ol5z6L0umKv yehhb4C6VOjTWYT37ep6 =iIhy -----END PGP SIGNATURE----- --n8g4imXOkfNTN/H1--