From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44880)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1a1lbI-0002K8-2H
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 20:43:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1a1lbD-0007bj-IV
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 20:43:55 -0500
Received: from mga11.intel.com ([192.55.52.93]:7706)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1a1lbD-0007aM-CL
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 20:43:51 -0500
Date: Thu, 26 Nov 2015 09:46:08 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Message-ID: <20151126014608.GN2325@yliu-dev.sh.intel.com>
References: <1448455324-31122-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448455324-31122-1-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at
	start/stop"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Thibaut Collet <thibaut.collet@6wind.com>, qemu-devel@nongnu.org

On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote:
> This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76.
> 
> In case of live migration several queues can be enabled and not only the
> first one. So informing backend that only the first queue is enabled is
> wrong.

Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

BTW, we should also update the spec about ring stop, right?

	--yliu
> 
> Reported-by: Thibaut Collet <thibaut.collet@6wind.com>
> Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/virtio/vhost.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 1794f0d..de29968 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -1226,11 +1226,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
>          }
>      }
>  
> -    if (hdev->vhost_ops->vhost_set_vring_enable) {
> -        /* only enable first vq pair by default */
> -        hdev->vhost_ops->vhost_set_vring_enable(hdev, hdev->vq_index == 0);
> -    }
> -
>      return 0;
>  fail_log:
>      vhost_log_put(hdev, false);
> @@ -1261,10 +1256,6 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev)
>                               hdev->vq_index + i);
>      }
>  
> -    if (hdev->vhost_ops->vhost_set_vring_enable) {
> -        hdev->vhost_ops->vhost_set_vring_enable(hdev, 0);
> -    }
> -
>      vhost_log_put(hdev, true);
>      hdev->started = false;
>      hdev->log = NULL;
> -- 
> MST