From: Fam Zheng <famz@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 01/14] block: Add "file" output parameter to block status query functions
Date: Thu, 26 Nov 2015 13:53:23 +0800 [thread overview]
Message-ID: <20151126055323.GG14630@ad.usersys.redhat.com> (raw)
In-Reply-To: <56569290.5030308@redhat.com>
On Wed, 11/25 22:03, Eric Blake wrote:
> On 11/25/2015 12:39 AM, Fam Zheng wrote:
> > The added parameter can be used to return the BDS pointer which the
> > valid offset is referring to. It's value should be ignored unless
>
> s/It's/Its/ (remember, "It's" is valid only if "It is" also works in
> the same place)
Right, it's just easy to typo. Thanks :)
Fam
>
> > BDRV_BLOCK_OFFSET_VALID in ret is set.
> >
> > Until block drivers fill in the right value, let's clear it explicitly
> > right before calling .bdrv_get_block_status.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
>
> With that fix,
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
next prev parent reply other threads:[~2015-11-26 5:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 7:38 [Qemu-devel] [PATCH v2 00/14] qemu-img map: Allow driver to return file of the allocated block Fam Zheng
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 01/14] block: Add "file" output parameter to block status query functions Fam Zheng
2015-11-26 5:03 ` Eric Blake
2015-11-26 5:53 ` Fam Zheng [this message]
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 02/14] qcow: Assign bs->file->bs to file in qcow_co_get_block_status Fam Zheng
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status Fam Zheng
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 04/14] raw: Assign bs to file in raw_co_get_block_status Fam Zheng
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status Fam Zheng
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status Fam Zheng
2015-11-25 16:28 ` Eric Blake
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 07/14] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status Fam Zheng
2015-11-25 16:38 ` Eric Blake
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 08/14] sheepdog: Assign bs to file in sd_co_get_block_status Fam Zheng
2015-11-26 5:03 ` Eric Blake
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 09/14] vdi: Assign bs->file->bs to file in vdi_co_get_block_status Fam Zheng
2015-11-26 5:04 ` Eric Blake
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 10/14] vpc: Assign bs->file->bs to file in vpc_co_get_block_status Fam Zheng
2015-11-26 5:04 ` Eric Blake
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 11/14] vmdk: Return extent's file in bdrv_get_block_status Fam Zheng
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct Fam Zheng
2015-11-25 11:37 ` Paolo Bonzini
2015-11-25 15:36 ` Eric Blake
2015-11-26 4:34 ` Fam Zheng
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 13/14] qemu-img: Use QAPI visitor to generate JSON Fam Zheng
2015-11-25 15:42 ` Eric Blake
2015-11-26 4:41 ` Fam Zheng
2015-11-25 7:39 ` [Qemu-devel] [PATCH v2 14/14] iotests: Add "qemu-img map" test for VMDK extents Fam Zheng
2015-11-25 15:43 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126055323.GG14630@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).