From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1pUr-0000Hr-PT for qemu-devel@nongnu.org; Thu, 26 Nov 2015 00:53:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1pUq-0001C2-TW for qemu-devel@nongnu.org; Thu, 26 Nov 2015 00:53:33 -0500 Date: Thu, 26 Nov 2015 13:53:23 +0800 From: Fam Zheng Message-ID: <20151126055323.GG14630@ad.usersys.redhat.com> References: <1448437153-27090-1-git-send-email-famz@redhat.com> <1448437153-27090-2-git-send-email-famz@redhat.com> <56569290.5030308@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56569290.5030308@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 01/14] block: Add "file" output parameter to block status query functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , Peter Lieven , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini On Wed, 11/25 22:03, Eric Blake wrote: > On 11/25/2015 12:39 AM, Fam Zheng wrote: > > The added parameter can be used to return the BDS pointer which the > > valid offset is referring to. It's value should be ignored unless > > s/It's/Its/ (remember, "It's" is valid only if "It is" also works in > the same place) Right, it's just easy to typo. Thanks :) Fam > > > BDRV_BLOCK_OFFSET_VALID in ret is set. > > > > Until block drivers fill in the right value, let's clear it explicitly > > right before calling .bdrv_get_block_status. > > > > Signed-off-by: Fam Zheng > > --- > > With that fix, > Reviewed-by: Eric Blake > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >