Re: [Qemu-devel] [PATCH] Fix memory leak on error

[Igor Mammedov <imammedo@redhat.com>]

On Thu, 26 Nov 2015 12:00:12 +0000
Stefano Dong (董兴水) <opensource.dxs@aliyun.com> wrote:

> hw/ppc/spapr.c: Fix memory leak on error, it was introduced in bc09e0611
> hw/acpi/memory_hotplug.c: Fix memory leak on error, it was introduced in 34f2af3d
> 
> Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>


> ---
>  hw/acpi/memory_hotplug.c | 1 +
>  hw/ppc/spapr.c           | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
> index ce428df..e4b9a01 100644
> --- a/hw/acpi/memory_hotplug.c
> +++ b/hw/acpi/memory_hotplug.c
> @@ -155,6 +155,7 @@ static void acpi_memory_hotplug_write(void *opaque, hwaddr addr, uint64_t data,
>                  qapi_event_send_mem_unplug_error(dev->id,
>                                                   error_get_pretty(local_err),
>                                                   &error_abort);
> +                error_free(local_err);
>                  break;
>              }
>              trace_mhp_acpi_pc_dimm_deleted(mem_st->selector);
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 030ee35..3bb8bcd 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -125,6 +125,7 @@ static XICSState *xics_system_init(MachineState *machine,
>              error_report("kernel_irqchip requested but unavailable: %s",
>                           error_get_pretty(err));
>          }
> +        error_free(err);
>      }
>  
>      if (!icp) {