From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54547)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1zn4-0003D3-Pt
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 11:53:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1zn1-0000yo-Jm
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 11:53:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41911)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a1zn1-0000yi-EG
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 11:52:59 -0500
Date: Thu, 26 Nov 2015 18:52:56 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151126185227-mutt-send-email-mst@redhat.com>
References: <1448455324-31122-1-git-send-email-mst@redhat.com>
	<20151126014608.GN2325@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151126014608.GN2325@yliu-dev.sh.intel.com>
Subject: Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at
	start/stop"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Thibaut Collet <thibaut.collet@6wind.com>, qemu-devel@nongnu.org

On Thu, Nov 26, 2015 at 09:46:08AM +0800, Yuanhan Liu wrote:
> On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote:
> > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76.
> > 
> > In case of live migration several queues can be enabled and not only the
> > first one. So informing backend that only the first queue is enabled is
> > wrong.
> 
> Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> 
> BTW, we should also update the spec about ring stop, right?
> 
> 	--yliu

Pls take a look at for_upstream in my tree, and tell me
whether there's anything we need to clarify.

> > 
> > Reported-by: Thibaut Collet <thibaut.collet@6wind.com>
> > Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/virtio/vhost.c | 9 ---------
> >  1 file changed, 9 deletions(-)
> > 
> > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> > index 1794f0d..de29968 100644
> > --- a/hw/virtio/vhost.c
> > +++ b/hw/virtio/vhost.c
> > @@ -1226,11 +1226,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
> >          }
> >      }
> >  
> > -    if (hdev->vhost_ops->vhost_set_vring_enable) {
> > -        /* only enable first vq pair by default */
> > -        hdev->vhost_ops->vhost_set_vring_enable(hdev, hdev->vq_index == 0);
> > -    }
> > -
> >      return 0;
> >  fail_log:
> >      vhost_log_put(hdev, false);
> > @@ -1261,10 +1256,6 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev)
> >                               hdev->vq_index + i);
> >      }
> >  
> > -    if (hdev->vhost_ops->vhost_set_vring_enable) {
> > -        hdev->vhost_ops->vhost_set_vring_enable(hdev, 0);
> > -    }
> > -
> >      vhost_log_put(hdev, true);
> >      hdev->started = false;
> >      hdev->log = NULL;
> > -- 
> > MST