From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a26PI-0004J7-H8 for qemu-devel@nongnu.org; Thu, 26 Nov 2015 18:56:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a26PE-0006Zh-DX for qemu-devel@nongnu.org; Thu, 26 Nov 2015 18:56:56 -0500 Date: Fri, 27 Nov 2015 10:46:20 +1100 From: David Gibson Message-ID: <20151126234620.GB25500@voom.redhat.com> References: <1447051637-45246-1-git-send-email-aik@ozlabs.ru> <20151109084731.GH18558@voom.redhat.com> <564C2CA3.8000307@ozlabs.ru> <20151118104927.GA3298@voom.fritz.box> <5655D075.9020609@suse.de> <20151126004911.GA25500@voom.redhat.com> <56568A93.6090307@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dc+cDN39EJAMEtIO" Content-Disposition: inline In-Reply-To: <56568A93.6090307@ozlabs.ru> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Add /system-id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org --dc+cDN39EJAMEtIO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 26, 2015 at 03:29:07PM +1100, Alexey Kardashevskiy wrote: > On 11/26/2015 11:49 AM, David Gibson wrote: > >On Wed, Nov 25, 2015 at 04:15:01PM +0100, Alexander Graf wrote: > >> > >> > >>On 18.11.15 11:49, David Gibson wrote: > >>>On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey Kardashevskiy wrote: > >>>>On 11/09/2015 07:47 PM, David Gibson wrote: > >>>>>On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote: > >>>>>>Section B.6.2.1 Root Node Properties of PAPR specification defines > >>>>>>a set of properties which shall be present in the device tree root, > >>>>>>one of these properties is "system-id" which "should be unique acro= ss > >>>>>>all systems and all manufacturers". Since UUID is meant to be uniqu= e, > >>>>>>it makes sense to use it as "system-id". > >>>>>> > >>>>>>This adds "system-id" property to the device tree root when not emp= ty. > >>>>>> > >>>>>>Signed-off-by: Alexey Kardashevskiy > >>>>>>--- > >>>>>> > >>>>>>This might be expected by AIX so here is the patch. > >>>>>>I am really not sure if it makes sense to initialize property when > >>>>>>UUID is all zeroes as the requirement is "unique" and zero-uuid is > >>>>>>not. > >>>>> > >>>>>Yeah, I think it would be better to omit system-id entirely when a > >>>>>UUID hasn't been supplied. > >>>> > >>>> > >>>>so this did not go anywhere yet, did it? > >>> > >>>No. > >> > >>So where is it stuck? > > > >I was waiting for a respin which didn't set the property when a UUID > >hadn't been given. > > >=20 > This is the original patch: >=20 >=20 > + if (qemu_uuid_set) { > + _FDT((fdt_property_string(fdt, "system-id", buf))); > + } >=20 > I does not set property if qemu_uuid_set=3D=3Dfalse already. What did I m= iss? Oh, sorry, I misread the original patch. I thought you were saying that if UUID wasn't specified, it would appear as a system-id of all 0s. Applied to ppc-for-2.6. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --dc+cDN39EJAMEtIO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWV5nMAAoJEGw4ysog2bOSxiMQAKdbA/wqERdvgyZpsFNBW9cr XtPe0iI1nWDllG1fS+wuNh06G54cFHp4KPLzoDhZz0N9iteQvERuLeousJdzMyFF j9oJe8oNMd1/tFWKbv/QqL7QHM0wTXe1XpxM++rtsmjIrB8YmhfWLEAsUcv2zfmb mppbJeZWHtCpEyY0OZQI/zADV1u6QZ6hXteaOll2/4aI/qMbxpCparuV73wKPHkJ yOtO5N82wAuesx/e6NqeX5t8yGlpEhV9gk6riXYpA8IhIVXr2oCWa35kyd50L8l+ PnB2F2VqhKtLoWQo05Ge/JV1GMh4cW1Q6Cf72lyoIWEjeFeOhnp49YdYh6ASJW8l 2OIeIKSiGjv0+sikQCFdN+JaFwePxCXq3NEQMjVDqZ19/1LlErsEdkfgBbtj8Sws gg7WvBqISjePNsbvT672GAg2N5tHqmWiLLQlirCw0ot1VAGUX+9+UV1GpnFEH/uz rSRFxn1P57CsmjuNl5Q5keDaHZusjyI6U7n5QYV/6QoIc+4r9K4+zY5ku6Ap63Nl fTeBHAklTw4SgXrld+jJZ7BduPtYSU2HOSikg0EwoZkP/sU/lZGiQDkttdjKPa9E K2EIJ07u+5oVmJxQPZfug1BJ2ETOKXPfkBE0wXI+gyscDMcN4Cp+MgaLy09CqMJr 0BiP3gr/5DhU+cQAPR44 =t0Sp -----END PGP SIGNATURE----- --dc+cDN39EJAMEtIO--