From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Thibaut Collet <thibaut.collet@6wind.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"
Date: Fri, 27 Nov 2015 12:34:54 +0800 [thread overview]
Message-ID: <20151127043454.GO2325@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20151126185227-mutt-send-email-mst@redhat.com>
On Thu, Nov 26, 2015 at 06:52:56PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 26, 2015 at 09:46:08AM +0800, Yuanhan Liu wrote:
> > On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote:
> > > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76.
> > >
> > > In case of live migration several queues can be enabled and not only the
> > > first one. So informing backend that only the first queue is enabled is
> > > wrong.
> >
> > Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >
> > BTW, we should also update the spec about ring stop, right?
> >
> > --yliu
>
> Pls take a look at for_upstream in my tree, and tell me
> whether there's anything we need to clarify.
I had a quick check, and found it's fine. I was thinking we are
still clarifying that there are two ways for signing a ring stop:
VHOST_USER_GET_VRING_BASE and VHOST_UESR_SET_VRING_ENABLE.
Sorry for the noisy then.
--yliu
prev parent reply other threads:[~2015-11-27 4:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 12:42 [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop" Michael S. Tsirkin
2015-11-25 15:45 ` Thibaut Collet
2015-11-26 1:46 ` Yuanhan Liu
2015-11-26 16:52 ` Michael S. Tsirkin
2015-11-27 4:34 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151127043454.GO2325@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thibaut.collet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).