From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48803)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1a2Ahy-00031T-Kx
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 23:32:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1a2Ahv-00068N-FO
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 23:32:30 -0500
Received: from mga02.intel.com ([134.134.136.20]:6565)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1a2Ahv-00067y-9w
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 23:32:27 -0500
Date: Fri, 27 Nov 2015 12:34:54 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Message-ID: <20151127043454.GO2325@yliu-dev.sh.intel.com>
References: <1448455324-31122-1-git-send-email-mst@redhat.com>
	<20151126014608.GN2325@yliu-dev.sh.intel.com>
	<20151126185227-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151126185227-mutt-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at
	start/stop"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Thibaut Collet <thibaut.collet@6wind.com>, qemu-devel@nongnu.org

On Thu, Nov 26, 2015 at 06:52:56PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 26, 2015 at 09:46:08AM +0800, Yuanhan Liu wrote:
> > On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote:
> > > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76.
> > > 
> > > In case of live migration several queues can be enabled and not only the
> > > first one. So informing backend that only the first queue is enabled is
> > > wrong.
> > 
> > Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > 
> > BTW, we should also update the spec about ring stop, right?
> > 
> > 	--yliu
> 
> Pls take a look at for_upstream in my tree, and tell me
> whether there's anything we need to clarify.

I had a quick check, and found it's fine. I was thinking we are
still clarifying that there are two ways for signing a ring stop:
VHOST_USER_GET_VRING_BASE and VHOST_UESR_SET_VRING_ENABLE.

Sorry for the noisy then.

	--yliu