Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

[Fam Zheng <famz@redhat.com>]

On Fri, 11/27 10:48, Peter Xu wrote:
> @@ -1659,8 +1660,17 @@ static void dump_process(DumpState *s, Error **errp)
>  static void *dump_thread(void *data)
>  {
>      GlobalDumpState *global = (GlobalDumpState *)data;
> -    dump_process(global->gds_cur, NULL);
> +    Error *local_err = NULL;
> +    const char *msg = "Dump completed successfully";
> +
> +    dump_process(global->gds_cur, &local_err);
>      dump_state_release(global);
> +
> +    /* if detach is used, notify user that dump has finished */
> +    if (local_err) {
> +        msg = error_get_pretty(local_err);

error_free?


> +    }
> +    qapi_event_send_dump_completed(msg, &error_abort);
>      return NULL;
>  }
>