From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a2BRR-0000gh-TQ
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 00:19:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a2BRO-0005gW-P0
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 00:19:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60877)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a2BRO-0005gG-KA
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 00:19:26 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id 32B701456
	for <qemu-devel@nongnu.org>; Fri, 27 Nov 2015 05:19:26 +0000 (UTC)
Date: Fri, 27 Nov 2015 13:19:22 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151127051922.GA10018@ad.usersys.redhat.com>
References: <1448592497-2462-1-git-send-email-peterx@redhat.com>
	<1448592497-2462-5-git-send-email-peterx@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448592497-2462-5-git-send-email-peterx@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event
 DUMP_COMPLETED
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, 11/27 10:48, Peter Xu wrote:
> @@ -1659,8 +1660,17 @@ static void dump_process(DumpState *s, Error **errp)
>  static void *dump_thread(void *data)
>  {
>      GlobalDumpState *global = (GlobalDumpState *)data;
> -    dump_process(global->gds_cur, NULL);
> +    Error *local_err = NULL;
> +    const char *msg = "Dump completed successfully";
> +
> +    dump_process(global->gds_cur, &local_err);
>      dump_state_release(global);
> +
> +    /* if detach is used, notify user that dump has finished */
> +    if (local_err) {
> +        msg = error_get_pretty(local_err);

error_free?


> +    }
> +    qapi_event_send_dump_completed(msg, &error_abort);
>      return NULL;
>  }
>