From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2BSG-0001fK-B6 for qemu-devel@nongnu.org; Fri, 27 Nov 2015 00:20:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2BSD-0006En-91 for qemu-devel@nongnu.org; Fri, 27 Nov 2015 00:20:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2BSD-0006EW-4n for qemu-devel@nongnu.org; Fri, 27 Nov 2015 00:20:17 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A2648C0B7ABC for ; Fri, 27 Nov 2015 05:20:16 +0000 (UTC) Date: Fri, 27 Nov 2015 13:20:12 +0800 From: Fam Zheng Message-ID: <20151127052012.GB10018@ad.usersys.redhat.com> References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-4-git-send-email-peterx@redhat.com> <20151127051425.GC14568@ad.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151127051425.GC14568@ad.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org On Fri, 11/27 13:14, Fam Zheng wrote: > But what I really wonder is why a single boolean is not enough: the DumpState > pointer can be passed to dump_thread, so it doesn't need to be global, then you > don't need the mutex. Never mind, it's useful in later patches. Fam