From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35460)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2HDe-0006or-84
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:29:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2HDb-0003tX-I6
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:29:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46842)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2HDb-0003tJ-DD
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:29:35 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 1AEFE3423DA
	for <qemu-devel@nongnu.org>; Fri, 27 Nov 2015 11:29:35 +0000 (UTC)
Date: Fri, 27 Nov 2015 19:29:29 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20151127112928.GC10191@pxdev.xzpeter.org>
References: <1448592497-2462-1-git-send-email-peterx@redhat.com>
	<1448592497-2462-5-git-send-email-peterx@redhat.com>
	<56582D47.6040905@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <56582D47.6040905@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event
	DUMP_COMPLETED
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Nov 27, 2015 at 11:15:35AM +0100, Paolo Bonzini wrote:
> 
> 
> On 27/11/2015 03:48, Peter Xu wrote:
> > +##
> > +# @DUMP_COMPLETED
> > +#
> > +# Emitted when background dump has completed
> > +#
> > +# Since: 2.6
> > +##
> > +{ 'event': 'DUMP_COMPLETED' ,
> > +  'data': { 'msg': 'str' } }
> 
> This makes it hard to understand whether there was an error or not.  I
> suggest using '*error': 'str' instead, and omitting the error if the
> dump is successful.

Will adopt it. Thanks!

Peter

> 
> Paolo