From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2HHr-0002ST-5t
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:33:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2HHo-0004y2-0Q
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:33:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60781)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a2HHn-0004xq-S2
	for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:33:55 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id 9518AC0D2223
	for <qemu-devel@nongnu.org>; Fri, 27 Nov 2015 11:33:55 +0000 (UTC)
Date: Fri, 27 Nov 2015 19:33:49 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20151127113348.GD10191@pxdev.xzpeter.org>
References: <1448592497-2462-1-git-send-email-peterx@redhat.com>
	<1448592497-2462-6-git-send-email-peterx@redhat.com>
	<20151127052523.GC10018@ad.usersys.redhat.com>
	<56580031.5070405@redhat.com> <56582DD0.50109@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <56582DD0.50109@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query"
 command to query dump status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org

On Fri, Nov 27, 2015 at 11:17:52AM +0100, Paolo Bonzini wrote:
> 
> 
> On 27/11/2015 08:03, Peter Xu wrote:
> > > > +{ 'struct': 'DumpStatus',
> > > > +  'data': { 'status': 'str', 'percentage': 'str' } }
> > > 
> > > I suggest using enum for "status" and int for "percentage" (or two ints for
> > > "total" and "current").
> > 
> > Yes, I picked string just for flexibility. Regarding to this
> > interface issue, I'd like to wait for others' comments too before
> > modification.
> 
> I like Fam's idea of using an enum and two ints.
> 
> Also, the command should be named query-dump and the corresponding HMP
> command should be "info dump" (by defining "dump" in hmp-commands-info.h".

Ok, will change in v3.

Thanks.
Peter

> 
> Paolo