From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Jg7-00025L-5K for qemu-devel@nongnu.org; Fri, 27 Nov 2015 09:07:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2Jg3-0004f2-3o for qemu-devel@nongnu.org; Fri, 27 Nov 2015 09:07:11 -0500 Received: from e06smtp06.uk.ibm.com ([195.75.94.102]:43601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Jg2-0004eX-PX for qemu-devel@nongnu.org; Fri, 27 Nov 2015 09:07:07 -0500 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 27 Nov 2015 14:07:04 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4B37E219005C for ; Fri, 27 Nov 2015 14:06:54 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tARE70HO6357392 for ; Fri, 27 Nov 2015 14:07:00 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tARE6xkc032357 for ; Fri, 27 Nov 2015 07:07:00 -0700 Date: Fri, 27 Nov 2015 15:06:53 +0100 From: Greg Kurz Message-ID: <20151127150653.449e596f@bahia.local> In-Reply-To: <565855DF.5060100@redhat.com> References: <1448624586-28299-2-git-send-email-pbonzini@redhat.com> <20151127134246.3a33702d@bahia.local> <565855DF.5060100@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5] virtio-9p: use QEMU thread pool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com On Fri, 27 Nov 2015 14:08:47 +0100 Paolo Bonzini wrote: > > > On 27/11/2015 13:42, Greg Kurz wrote: > > On Fri, 27 Nov 2015 12:43:06 +0100 > > Paolo Bonzini wrote: > > > >> The QEMU thread pool already has a mechanism to invoke callbacks in the main > >> thread. It does not need an EventNotifier and it is more efficient too. > >> Use it instead of GAsyncQueue + GThreadPool + glue. > >> > >> As a side effect, it silences Coverity's complaint about an unchecked > >> return value for event_notifier_init. > > > > And it makes the code a lot nicer too ! > > Thanks. :) > > >> Signed-off-by: Paolo Bonzini > >> --- > > > > I have just one minor remark in hw/9pfs/virtio-9p-coth.h but anyway: > > > > Reviewed-by: Greg Kurz > > Tested-by: Greg Kurz > > Would you like to send a pull request for these patches yourself, and > possibly add yourself to MAINTAINERS? I can help you setting up git > (next week). > > Paolo > I'd be glad to. I'll ping you next week then :) Cheers. -- Greg