From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60682)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a3DaB-0003kr-0R
	for qemu-devel@nongnu.org; Sun, 29 Nov 2015 20:48:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a3Da6-0005xo-1K
	for qemu-devel@nongnu.org; Sun, 29 Nov 2015 20:48:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55114)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a3Da5-0005wT-Ro
	for qemu-devel@nongnu.org; Sun, 29 Nov 2015 20:48:41 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id DF451C0D222F
	for <qemu-devel@nongnu.org>; Mon, 30 Nov 2015 01:48:40 +0000 (UTC)
Date: Mon, 30 Nov 2015 09:48:38 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151130014838.GA10896@ad.usersys.redhat.com>
References: <1448592497-2462-1-git-send-email-peterx@redhat.com>
	<1448592497-2462-4-git-send-email-peterx@redhat.com>
	<20151127051425.GC14568@ad.usersys.redhat.com>
	<20151128055122.GA16816@pxdev.xzpeter.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151128055122.GA16816@pxdev.xzpeter.org>
Subject: Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic
 "detach" support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On Sat, 11/28 13:51, Peter Xu wrote:
> On Fri, Nov 27, 2015 at 01:14:25PM +0800, Fam Zheng wrote:
> > On Fri, 11/27 10:48, Peter Xu wrote:
> 
> [snip]
> 
> > 
> > This patch doesn't handle the incoming migration case, i.e. when QEMU is
> > started with "-incoming", or "-incoming defer". Dump can go wrong when incoming
> > migration happens at the same time.
> 
> Sorry to missed these lines. Still not understand why this patch
> cannot handle this if with [1] (Please check below for [1])?

You're right, that does work. I missed that "defer" also sets
RUN_STATE_INMIGRATE.

Fam