From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 01/15] block: Add "file" output parameter to block status query functions
Date: Mon, 30 Nov 2015 17:09:49 +0800 [thread overview]
Message-ID: <20151130090948.GA5038@ad.usersys.redhat.com> (raw)
In-Reply-To: <20151130083848.GC18454@stefanha-x1.localdomain>
On Mon, 11/30 16:38, Stefan Hajnoczi wrote:
> On Thu, Nov 26, 2015 at 01:05:21PM +0800, Fam Zheng wrote:
> > @@ -1535,13 +1541,14 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs,
> > }
> > }
> >
> > - if (bs->file &&
> > + if (*file && *file != bs &&
> > (ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO) &&
> > (ret & BDRV_BLOCK_OFFSET_VALID)) {
>
> What is the purpose of this change?
The code here is to sensibly detect "zero" by going into the "file" which the
offset is valid for. Now the "file" is no longer always "bs->file", so we use
the returned "file" pointer instead.
Fam
next prev parent reply other threads:[~2015-11-30 9:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 5:05 [Qemu-devel] [PATCH v3 00/15] qemu-img map: Allow driver to return file of the allocated block Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 01/15] block: Add "file" output parameter to block status query functions Fam Zheng
2015-11-30 8:38 ` Stefan Hajnoczi
2015-11-30 9:09 ` Fam Zheng [this message]
2015-12-01 9:25 ` Stefan Hajnoczi
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 02/15] qcow: Assign bs->file->bs to file in qcow_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 03/15] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 04/15] raw: Assign bs to file in raw_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 05/15] iscsi: Assign bs to file in iscsi_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 06/15] parallels: Assign bs->file->bs to file in parallels_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 07/15] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 08/15] sheepdog: Assign bs to file in sd_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 10/15] vpc: Assign bs->file->bs to file in vpc_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 11/15] vmdk: Return extent's file in bdrv_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 12/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status Fam Zheng
2015-11-26 5:21 ` Eric Blake
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct Fam Zheng
2015-11-26 5:19 ` Eric Blake
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 14/15] qemu-img: Use QAPI visitor to generate JSON Fam Zheng
2015-12-10 22:09 ` Eric Blake
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 15/15] iotests: Add "qemu-img map" test for VMDK extents Fam Zheng
2015-11-30 8:43 ` [Qemu-devel] [PATCH v3 00/15] qemu-img map: Allow driver to return file of the allocated block Stefan Hajnoczi
2015-12-01 9:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130090948.GA5038@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).