From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3ZkD-0002cQ-Sr for qemu-devel@nongnu.org; Mon, 30 Nov 2015 20:28:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3Zk8-0005kL-TK for qemu-devel@nongnu.org; Mon, 30 Nov 2015 20:28:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3Zk8-0005kH-Nn for qemu-devel@nongnu.org; Mon, 30 Nov 2015 20:28:32 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 0126B42E5B2 for ; Tue, 1 Dec 2015 01:28:31 +0000 (UTC) Date: Tue, 1 Dec 2015 09:28:23 +0800 From: Peter Xu Message-ID: <20151201012822.GA21032@pxdev.xzpeter.org> References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-3-git-send-email-peterx@redhat.com> <565C93A3.1050302@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <565C93A3.1050302@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org On Mon, Nov 30, 2015 at 11:21:23AM -0700, Eric Blake wrote: > On 11/26/2015 07:48 PM, Peter Xu wrote: > > This patch only adds the interfaces, but not implements them. > > s/not implements/does not implement/ > > > "detach" parameter is made optional, to make sure that all the old > > dump-guest-memory requests will still be able to work. > > > > Signed-off-by: Peter Xu > > --- > > In addition to Fam's comments, > > > +++ b/qapi-schema.json > > @@ -2115,6 +2115,9 @@ > > # 2. fd: the protocol starts with "fd:", and the following string > > # is the fd's name. > > # > > +# @detach: #optional if true, QMP will return immediately rather than > > +# waiting dump to be finished (since 2.6). > > s/waiting/waiting for the/ > s/be finished/finish/ > > > +++ b/qmp-commands.hx > > @@ -840,8 +840,8 @@ EQMP > > > > { > > .name = "dump-guest-memory", > > - .args_type = "paging:b,protocol:s,begin:i?,end:i?,format:s?", > > - .params = "-p protocol [begin] [length] [format]", > > + .args_type = "paging:b,protocol:s,detach:b?,begin:i?,end:i?,format:s?", > > + .params = "-p protocol [-d] [begin] [length] [format]", > > .help = "dump guest memory to file", > > .mhandler.cmd_new = qmp_marshal_dump_guest_memory, > > }, > > @@ -857,6 +857,8 @@ Arguments: > > - "paging": do paging to get guest's memory mapping (json-bool) > > - "protocol": destination file(started with "file:") or destination file > > descriptor (started with "fd:") (json-string) > > +- "detach": if specificed, command will return immediately, without waiting > > s/specificed/specified/ > > > + for dump to be finished (json-bool) > > s/dump to be finished/the dump to finish/ Thanks for the corrections. These errors exist in v3 too. Will fix them in v4. Peter > > > - "begin": the starting physical address. It's optional, and should be specified > > with length together (json-int) > > - "length": the memory size, in bytes. It's optional, and should be specified > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >