From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3a7h-00022S-0Z for qemu-devel@nongnu.org; Mon, 30 Nov 2015 20:52:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3a7d-00031Y-Qe for qemu-devel@nongnu.org; Mon, 30 Nov 2015 20:52:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3a7d-00031M-L1 for qemu-devel@nongnu.org; Mon, 30 Nov 2015 20:52:49 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id CB73568E26 for ; Tue, 1 Dec 2015 01:52:48 +0000 (UTC) Date: Tue, 1 Dec 2015 09:52:40 +0800 From: Peter Xu Message-ID: <20151201015237.GB21032@pxdev.xzpeter.org> References: <1448592497-2462-1-git-send-email-peterx@redhat.com> <1448592497-2462-5-git-send-email-peterx@redhat.com> <565C9308.3090901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <565C9308.3090901@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org On Mon, Nov 30, 2015 at 11:18:48AM -0700, Eric Blake wrote: > On 11/26/2015 07:48 PM, Peter Xu wrote: > > To get aligned with QMP interface, one new QMP event DUMP_COMPLETED > > is added. It is used when user specified "detach" in dump, and > > triggered when the dump finishes. Error message will be appended to > > this event if the dump has failed. > > Why not emit the new event unconditionally, instead of only when detach > was specified? I was just trying to make sure that dump will work exactly as it is when detach is not used. Yes, I think I could emit it unconditionally if libvirt does not complain about it. :) > > > > > Signed-off-by: Peter Xu > > --- > > docs/qmp-events.txt | 12 ++++++++++++ > > dump.c | 12 +++++++++++- > > qapi/event.json | 10 ++++++++++ > > 3 files changed, 33 insertions(+), 1 deletion(-) > > > > diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt > > index d2f1ce4..fe494f9 100644 > > --- a/docs/qmp-events.txt > > +++ b/docs/qmp-events.txt > > @@ -674,3 +674,15 @@ Note: If action is "reset", "shutdown", or "pause" the WATCHDOG event is > > followed respectively by the RESET, SHUTDOWN, or STOP events. > > > > Note: this event is rate-limited. > > + > > +DUMP_COMPLETED > > +-------------- > > + > > +Emitted when the guest has finished one memory dump. > > + > > +Data: None. > > Wrong - you have 'msg' as data. Except that Paolo is right, 'msg' > should be optional, and only present on error. You should also document > that the contents of 'msg' are for human consumption and should not be > machine-parsed (basically, only the presence of absence of 'msg' is > useful for machines). I will make sure v4 contains these suggestions. Thanks. > > > + > > +Example: > > + > > +{ "event": "DUMP_COMPLETED", > > + "data": { "msg": "Dump completed successfully" } } > > diff --git a/dump.c b/dump.c > > > +++ b/qapi/event.json > > @@ -356,3 +356,13 @@ > > ## > > { 'event': 'MEM_UNPLUG_ERROR', > > 'data': { 'device': 'str', 'msg': 'str' } } > > + > > +## > > +# @DUMP_COMPLETED > > +# > > +# Emitted when background dump has completed > > +# > > Missing documentation of 'msg', which should be optional. Sorry I missed that. Thanks to point out! Peter > > > +# Since: 2.6 > > +## > > +{ 'event': 'DUMP_COMPLETED' , > > + 'data': { 'msg': 'str' } } > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >