Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus

[Peter Xu <peterx@redhat.com>]

On Mon, Nov 30, 2015 at 03:08:24PM -0700, Eric Blake wrote:
> On 11/30/2015 04:32 AM, Peter Xu wrote:
> > Instead of malloc/free each time for DumpState, make it
> > static. Added DumpStatus to show status for dump.
> > 
> > This is to be used for detach dump.
> 
> s/detach/detached/
> 
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  dump.c                | 30 +++++++++++++++++++++++++++---
> >  include/sysemu/dump.h |  2 ++
> >  qapi-schema.json      | 18 ++++++++++++++++++
> >  3 files changed, 47 insertions(+), 3 deletions(-)
> > 
> 
> In addition to Paolo's review,
> 
> > +++ b/qapi-schema.json
> > @@ -2139,6 +2139,24 @@
> >              '*format': 'DumpGuestMemoryFormat'} }
> >  
> >  ##
> > +# @DumpStatus
> > +#
> > +# Define the status for dump guest memory.
> 
> Reads awkwardly.  Maybe:
> 
> Describe the status of a long-running background guest memory dump.
> 
> > +#
> > +# @none: not started any dump-guest-memory yet.
> 
> @none: no dump-guest-memory has started yet
> 
> > +#
> > +# @active: there is one dump running in background.
> > +#
> > +# @completed: the last dump has finished sucessfully
> 
> s/sucessfully/successfully/
> 
> Inconsistent on whether your lines end in '.'

Will fix above all in v4.

Thanks!
Peter

> 
> > +#
> > +# @failed: the last dump has failed.
> > +#
> > +# Since 2.6
> > +##
> > +{ 'enum': 'DumpStatus',
> > +  'data': [ 'none', 'active', 'completed', 'failed' ] }
> > +
> > +##
> >  # @DumpGuestMemoryCapability:
> >  #
> >  # A list of the available formats for dump-guest-memory
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>