From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3bFB-00087x-In
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 22:04:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3bF6-0002Al-AM
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 22:04:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3bF6-0002AL-4x
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 22:04:36 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 0F3C4C0D2221
	for <qemu-devel@nongnu.org>; Tue,  1 Dec 2015 03:04:34 +0000 (UTC)
Date: Tue, 1 Dec 2015 11:04:20 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20151201030418.GF21032@pxdev.xzpeter.org>
References: <1448883140-20249-1-git-send-email-peterx@redhat.com>
	<1448883140-20249-4-git-send-email-peterx@redhat.com>
	<565CC8D8.4020607@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <565CC8D8.4020607@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static
 DumpState, add DumpStatus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: drjones@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, famz@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, lersek@redhat.com

On Mon, Nov 30, 2015 at 03:08:24PM -0700, Eric Blake wrote:
> On 11/30/2015 04:32 AM, Peter Xu wrote:
> > Instead of malloc/free each time for DumpState, make it
> > static. Added DumpStatus to show status for dump.
> > 
> > This is to be used for detach dump.
> 
> s/detach/detached/
> 
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  dump.c                | 30 +++++++++++++++++++++++++++---
> >  include/sysemu/dump.h |  2 ++
> >  qapi-schema.json      | 18 ++++++++++++++++++
> >  3 files changed, 47 insertions(+), 3 deletions(-)
> > 
> 
> In addition to Paolo's review,
> 
> > +++ b/qapi-schema.json
> > @@ -2139,6 +2139,24 @@
> >              '*format': 'DumpGuestMemoryFormat'} }
> >  
> >  ##
> > +# @DumpStatus
> > +#
> > +# Define the status for dump guest memory.
> 
> Reads awkwardly.  Maybe:
> 
> Describe the status of a long-running background guest memory dump.
> 
> > +#
> > +# @none: not started any dump-guest-memory yet.
> 
> @none: no dump-guest-memory has started yet
> 
> > +#
> > +# @active: there is one dump running in background.
> > +#
> > +# @completed: the last dump has finished sucessfully
> 
> s/sucessfully/successfully/
> 
> Inconsistent on whether your lines end in '.'

Will fix above all in v4.

Thanks!
Peter

> 
> > +#
> > +# @failed: the last dump has failed.
> > +#
> > +# Since 2.6
> > +##
> > +{ 'enum': 'DumpStatus',
> > +  'data': [ 'none', 'active', 'completed', 'failed' ] }
> > +
> > +##
> >  # @DumpGuestMemoryCapability:
> >  #
> >  # A list of the available formats for dump-guest-memory
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>