From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3bMa-0001mC-LM for qemu-devel@nongnu.org; Mon, 30 Nov 2015 22:12:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3bMW-0006Jt-Ha for qemu-devel@nongnu.org; Mon, 30 Nov 2015 22:12:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3bMW-0006Jh-CF for qemu-devel@nongnu.org; Mon, 30 Nov 2015 22:12:16 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id B6655C0B7AAC for ; Tue, 1 Dec 2015 03:12:15 +0000 (UTC) Date: Tue, 1 Dec 2015 11:12:00 +0800 From: Peter Xu Message-ID: <20151201031158.GG21032@pxdev.xzpeter.org> References: <1448883140-20249-1-git-send-email-peterx@redhat.com> <1448883140-20249-6-git-send-email-peterx@redhat.com> <565C4725.4000604@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <565C4725.4000604@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, famz@redhat.com, lcapitulino@redhat.com On Mon, Nov 30, 2015 at 01:55:01PM +0100, Paolo Bonzini wrote: > > > On 30/11/2015 12:32, Peter Xu wrote: > > if (*errp) { > > s->status = DUMP_STATUS_FAILED; > > Why not move this "if" to dump_process as well? Yes. I did that in another patch. I will move it to this patch, which should be better. Thanks. Peter > > Paolo