From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3d3E-0001eE-N3 for qemu-devel@nongnu.org; Tue, 01 Dec 2015 00:00:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3d3B-000540-AZ for qemu-devel@nongnu.org; Tue, 01 Dec 2015 00:00:28 -0500 Date: Tue, 1 Dec 2015 15:40:26 +1100 From: David Gibson Message-ID: <20151201044026.GQ31343@voom.redhat.com> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-35-git-send-email-benh@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RCJLo13VlymhPcEi" Content-Disposition: inline In-Reply-To: <1447201710-10229-35-git-send-email-benh@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 34/77] ppc/xics: An ICS with offset 0 is assumed to be uninitialized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --RCJLo13VlymhPcEi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 11, 2015 at 11:27:47AM +1100, Benjamin Herrenschmidt wrote: > This will make life easier for dealing with dynamically configured > ICSes such as PHB3 >=20 > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson > --- > include/hw/ppc/xics.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h > index 12fc584..51a63cb 100644 > --- a/include/hw/ppc/xics.h > +++ b/include/hw/ppc/xics.h > @@ -145,7 +145,7 @@ struct ICSState { > =20 > static inline bool ics_valid_irq(ICSState *ics, uint32_t nr) > { > - return (nr >=3D ics->offset) > + return (ics->offset !=3D 0) && (nr >=3D ics->offset) > && (nr < (ics->offset + ics->nr_irqs)); > } > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --RCJLo13VlymhPcEi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWXSS6AAoJEGw4ysog2bOSrakP/ibns5Z1lJp0+alTIHlH+gf/ cn0B0ArI3BXUIophv8GmyaiObCiCIyW1tHWFzVln3aiKmlALPIIhWusvcnxqMeGr XVOH6wxaymxXujQD+RrHSDpONC9Z2ieV20RTGOG53A005fogPbE99wJpHjlrTY3T VKeAPA1DbrqLRDpxSqVXkg6www4uV897lvxLYdD3jOnHCcKEE1JVitKR3LvJRoXi vNSJ7oTL2TN0I5nGEcYIa80Y+a7PJZkqMwFkMSL9aNn8GHLkYLFDGs9bcSbwKTzg vEd56QW1QLmOjdPK4ziqlShhnPAo/VdVcac6x96y9//nDo7RuhjyZP3cALwnZlHd HbnTIRIOOm9XusBcOTaft996Sih07TTV6abgJjBCXKk7Hn1GUfnPI2VAZqPh/rjl KKgexw8mi1DW4pz882sIZ/Rcpc2VafLGcKoXUN+YK6yt50Btuetd5PpYj+oxNGDp +cJOS703m8e33e+p1vwexlSlHBt6v6GM/6Zl9Hn+sDnoXeXtBvHJ0kSD8Ju0WbS5 MaPePqdSr1+EnRFwo/3pd29/H85JqnH7dGLyo314175sF0aepFboAtPOMVqHGDkP h8FBZmIyjaEKNd+Dvd/WbWPkTwj8iEyKVnwLEA2AZvTDEojXZTtN8jFp8EvYGcwn FakXnmsR4j6NgWpvE8qn =zkrI -----END PGP SIGNATURE----- --RCJLo13VlymhPcEi--