From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3eeQ-0001rN-BS for qemu-devel@nongnu.org; Tue, 01 Dec 2015 01:42:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3eeP-000307-CR for qemu-devel@nongnu.org; Tue, 01 Dec 2015 01:42:58 -0500 Date: Tue, 1 Dec 2015 17:39:00 +1100 From: David Gibson Message-ID: <20151201063900.GW31343@voom.redhat.com> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-39-git-send-email-benh@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8R/sMIKPJVD0CT2D" Content-Disposition: inline In-Reply-To: <1447201710-10229-39-git-send-email-benh@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 38/77] ppc/xics: Add "native" XICS subclass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --8R/sMIKPJVD0CT2D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 11, 2015 at 11:27:51AM +1100, Benjamin Herrenschmidt wrote: > This provides MMIO based ICP access as found on POWER8 >=20 > Signed-off-by: Benjamin Herrenschmidt [snip] > +static void xics_native_realize(DeviceState *dev, Error **errp) > +{ > + XICSState *s =3D XICS_NATIVE(dev); > + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); Ah.. here's another wrinkle. So the current XICS is defined as a SysBusDevice, but that's not actually correct because it doesn't have MMIO. But your xics native does have MMIO, so my understanding is that SysBusDevice is appropriate. Not sure how to handle that --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --8R/sMIKPJVD0CT2D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWXUCEAAoJEGw4ysog2bOSRvYQAKAOcAMYZv10KzeGGjOHEBB7 cbiRg3esZY0gFwH4PxnJXPmxHe3T7NGGc/LPxz9COmikWInFeWbZyYsVaQ2Ofein Ur878MkO+uWc942zHpTvauVDoyHm9izxTRcqEuxnAG/bmQWiScxM0wvrYJQwxKzl 1YiHeC6NuEx6mLMJylHby5FdpQMkZfujlPwjlCgBmcNAPBYO7JkKAdebbekGYGKW aD6HCf9jQ0VYpTlhbWmiBmhOO9NAJilEjr57eguryw1yvqDurd+IgYDqkuhZznI9 +hlf6unhBJfKHSI0dwFePaQfTj5mY4iqHEGyDZdFWGcatwJcHHO8G7R4+Ar5IhGI J0BWindL/ntppnpAgGS1yQ8fH3dvzWKv8Lgjh8r3DVhoViu/PlFZ6bMAJrowkyvR td+jKGb2T+LMjxdekxGMxZ30sPLJheDPFPfFwLfccyJSw8Jyk87ZQLOrDsFxa9SH iyFb11LYO2le37+7I+6KxSWioQy4bzARipMwIDrnaWahsSYPFbPidwBeNYBnEGhm kqaiMWVt/6DzPSMM4v3Bmq82wtTta4fwUns8XRriwJMDz4Ioew8Ifan61o6vP2j1 r8Stli2Wb9MtuyT6Fkiat8K/7gp63llzOQjiLblhC6RXrX9/1nVYeNeU+iEj8dOi lImMHwC4yy7SMg+kBh6U =VFMA -----END PGP SIGNATURE----- --8R/sMIKPJVD0CT2D--