From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3hC3-0003um-AK for qemu-devel@nongnu.org; Tue, 01 Dec 2015 04:25:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3hC2-0003NI-8h for qemu-devel@nongnu.org; Tue, 01 Dec 2015 04:25:51 -0500 Date: Tue, 1 Dec 2015 17:25:39 +0800 From: Stefan Hajnoczi Message-ID: <20151201092539.GD25001@stefanha-x1.localdomain> References: <1448514335-15988-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q9KOos5vDmpwPx9o" Content-Disposition: inline In-Reply-To: <1448514335-15988-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 00/15] qemu-img map: Allow driver to return file of the allocated block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , Peter Lieven , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini --q9KOos5vDmpwPx9o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 26, 2015 at 01:05:20PM +0800, Fam Zheng wrote: > v3: Add Eric's rev-by in patches 6, 7, 13, 14. > 12: New, split out from the previous 13. > 12->13: Refactor "entry_mergable" from imp_map(). > Don't mess the merge conditions. [Paolo] > Address Eric's comments: > - Check has_foo before using foo. > - Remove blank line between comments and definition in schema. > - Use PRId64 instead of %ld. > - Merge short lines. >=20 > v2: Add Eric's rev-by in patches 2, 4, 5. > 01: Refering -> referring in commit message. [Eric] > Recurse to "file" for sensible "zero" flag. [Paolo] > 12: New. Make MapEntry a QAPI struct. [Paolo, Markus] >=20 > I stumbled upon this when looking at external bitmap formats. >=20 > Current "qemu-img map" command only displays filename if the data is allo= cated > in bs (bs->file) itself, or in the backing chain. Otherwise, it displays = an > unfriendly error message: >=20 > $ qemu-img create -f vmdk -o subformat=3DmonolithicFlat /tmp/test.vmd= k 1G >=20 > $ qemu-img map /tmp/test.vmdk=20 > Offset Length Mapped to File > qemu-img: File contains external, encrypted or compressed clusters. >=20 > This can be improved. This series extends the .bdrv_co_get_block_status > callback, to let block driver return the BDS of file; then updates all dr= iver > to implement it; and lastly, it changes qemu-img to use this information = in > "map" command: >=20 > $ qemu-img map /tmp/test.vmdk=20 > Offset Length Mapped to File > 0 0x40000000 0 /tmp/test-flat.vmdk >=20 > $ qemu-img map --output json /tmp/test.vmdk=20 > [{"length": 1073741824, "start": 0, "zero": false, "offset": 0, "dept= h": 0, > "file": "/tmp/test-flat.vmdk", "data": true} > ] >=20 >=20 > Fam Zheng (15): > block: Add "file" output parameter to block status query functions > qcow: Assign bs->file->bs to file in qcow_co_get_block_status > qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status > raw: Assign bs to file in raw_co_get_block_status > iscsi: Assign bs to file in iscsi_co_get_block_status > parallels: Assign bs->file->bs to file in > parallels_co_get_block_status > qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status > sheepdog: Assign bs to file in sd_co_get_block_status > vdi: Assign bs->file->bs to file in vdi_co_get_block_status > vpc: Assign bs->file->bs to file in vpc_co_get_block_status > vmdk: Return extent's file in bdrv_get_block_status > qemu-img: In "map", use the returned "file" from bdrv_get_block_status > qemu-img: Make MapEntry a QAPI struct > qemu-img: Use QAPI visitor to generate JSON > iotests: Add "qemu-img map" test for VMDK extents >=20 > block/io.c | 42 ++++++++++++------- > block/iscsi.c | 9 +++- > block/mirror.c | 3 +- > block/parallels.c | 3 +- > block/qcow.c | 3 +- > block/qcow2.c | 3 +- > block/qed.c | 6 ++- > block/raw-posix.c | 4 +- > block/raw_bsd.c | 4 +- > block/sheepdog.c | 5 ++- > block/vdi.c | 3 +- > block/vmdk.c | 13 +++--- > block/vpc.c | 4 +- > block/vvfat.c | 2 +- > include/block/block.h | 6 ++- > include/block/block_int.h | 3 +- > qapi/block-core.json | 27 ++++++++++++ > qemu-img.c | 102 +++++++++++++++++++++++++++++----------= ------ > tests/qemu-iotests/059 | 10 +++++ > tests/qemu-iotests/059.out | 38 +++++++++++++++++ > tests/qemu-iotests/122.out | 96 +++++++++++++++++++++++----------------= --- > 21 files changed, 270 insertions(+), 116 deletions(-) >=20 > --=20 > 2.4.3 >=20 Reviewed-by: Stefan Hajnoczi --q9KOos5vDmpwPx9o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWXWeTAAoJEJykq7OBq3PIPmsH/idUM0V3unDDJssriZ2cuGCG ZZNLpX0pfZmxCW05U3ZAyb57ZJeTKHhafyoygraVbU5UwjMr+FL1zdmF4E+byuso yYoh/d46aN9Ud9M9kJsFga2HcMCa9la6XCdBIe1JDUMptjI6r/SFca3hy4Piw8qf oMb4UVUhktEycS8Dk8FKc5pxVUkp3xF25mH9imdrSkT/pxOmqQsjo3R6ERkxi2Ss JL6aQ3JzdvprcakYcE9kyxEEnYkEVnnkOIJ/5uqd9z6aqGlrdxQh32v8+4pZ5Yri UFBGts0A0vVckc4Kz7Nh4hmXyLaEHyZ8Nm+iSk4Y0xHan+xo6QxabxGVDt0sVp4= =HUjb -----END PGP SIGNATURE----- --q9KOos5vDmpwPx9o--