From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: Don't wait serialising for non-COR read requests
Date: Tue, 1 Dec 2015 10:54:36 +0100 [thread overview]
Message-ID: <20151201095436.GC6527@noname.str.redhat.com> (raw)
In-Reply-To: <1448962590-2842-2-git-send-email-famz@redhat.com>
Am 01.12.2015 um 10:36 hat Fam Zheng geschrieben:
> The assertion problem was noticed in 06c3916b35a, but it wasn't
> completely fixed, because even though the req is not marked as
> serialising, it still gets serialised by wait_serialising_requests
> against other serialising requests, which could lead to the same
> assertion failure.
>
> Fix it by even more explicitly skipping the serialising for this
> specific case.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
And this, my friends, is another example why read/write notifiers are
wrong and should die sooner rather than later. </broken-record>
Kevin
next prev parent reply other threads:[~2015-12-01 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 9:36 [Qemu-devel] [PATCH 0/3] block: Fix assertion failure with before write notifier again Fam Zheng
2015-12-01 9:36 ` [Qemu-devel] [PATCH 1/3] block: Don't wait serialising for non-COR read requests Fam Zheng
2015-12-01 9:54 ` Kevin Wolf [this message]
2015-12-01 10:26 ` Fam Zheng
2015-12-01 11:00 ` Kevin Wolf
2015-12-01 9:36 ` [Qemu-devel] [PATCH 2/3] iotests: Add "add_drive_raw" method Fam Zheng
2015-12-01 9:36 ` [Qemu-devel] [PATCH 3/3] iotests: Add regresion test case for write notifier assertion failure Fam Zheng
2015-12-03 6:50 ` [Qemu-devel] [PATCH 0/3] block: Fix assertion failure with before write notifier again Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201095436.GC6527@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).